Merge pull request microsoft#250664 from microsoft/osortega/fix-pending-promise

Fix for pending promise of aisearch

Author: osortega

src/vs/workbench/contrib/search/browser/searchTreeModel/searchModel.ts

@@ -115,7 +115,7 @@ export class SearchModelImpl extends Disposable implements ISearchModel {
 		return this._searchResult;
 	}
 
-	aiSearch(onResult: (result: ISearchProgressItem) => void): Promise<ISearchComplete> {
+	aiSearch(onResult: (result: ISearchProgressItem | undefined) => void): Promise<ISearchComplete> {
 		if (this.hasAIResults) {
 			// already has matches or pending matches
 			throw Error('AI results already exist');
@@ -138,6 +138,10 @@ export class SearchModelImpl extends Disposable implements ISearchModel {
 				tokenSource.dispose(true);
 			}).then(
 				value => {
+					if (value.results.length === 0) {
+						// alert of no results since onProgress won't be called
+						onResult(undefined);
+					}
 					this.onSearchCompleted(value, Date.now() - start, searchInstanceID, true);
 					return value;
 				},

src/vs/workbench/contrib/search/browser/searchTreeModel/searchTreeCommon.ts

@@ -97,7 +97,7 @@ export interface ISearchModel {
 	replaceString: string;
 	preserveCase: boolean;
 	searchResult: ISearchResult;
-	aiSearch(onResultReported: (result: ISearchProgressItem) => void): Promise<ISearchComplete>;
+	aiSearch(onResultReported: (result: ISearchProgressItem | undefined) => void): Promise<ISearchComplete>;
 	hasAIResults: boolean;
 	hasPlainResults: boolean;
 	search(query: ITextQuery, onProgress?: (result: ISearchProgressItem) => void, callerToken?: CancellationToken): {

src/vs/workbench/contrib/search/browser/searchView.ts

@@ -2095,7 +2095,7 @@ export class SearchView extends ViewPane {
 		if (!aiSearchPromise) {
 			this.viewModel.searchResult.setAIQueryUsingTextQuery();
 			aiSearchPromise = this._pendingSemanticSearchPromise = this.viewModel.aiSearch(result => {
-				if (isAIKeyword(result)) {
+				if (result && isAIKeyword(result)) {
 					this.updateKeywordSuggestionUI(result);
 					return;
 				}