Plumb custom mode body (microsoft#250250)

Towards microsoft/vscode-copilot#17638

Author: roblourens

src/vs/workbench/api/common/extHostTypeConverters.ts

@@ -2943,6 +2943,7 @@ export namespace ChatAgentRequest {
 			tools,
 			model,
 			editedFileEvents: request.editedFileEvents,
+			modeInstructions: request.modeInstructions,
 		};
 
 		if (!isProposedApiEnabled(extension, 'chatParticipantPrivate')) {

src/vs/workbench/contrib/chat/browser/chatWidget.ts

@@ -1333,6 +1333,7 @@ export class ChatWidget extends Disposable implements IChatWidget {
 				attachedContext: requestInputs.attachedContext,
 				noCommandDetection: options?.noCommandDetection,
 				userSelectedTools: this.getUserSelectedTools(),
+				modeInstructions: this.input.currentMode2.body
 			});
 
 			if (result) {
@@ -1371,6 +1372,14 @@ export class ChatWidget extends Disposable implements IChatWidget {
 		return undefined;
 	}
 
+	getModeRequestOptions(): Partial<IChatSendRequestOptions> {
+		return {
+			modeInstructions: this.input.currentMode2.body,
+			userSelectedTools: this.getUserSelectedTools(),
+			mode: this.input.currentMode,
+		};
+	}
+
 	getCodeBlockInfosForResponse(response: IChatResponseViewModel): IChatCodeBlockInfo[] {
 		return this.renderer.getCodeBlockInfosForResponse(response);
 	}

src/vs/workbench/contrib/chat/common/chatAgents.ts

@@ -137,6 +137,7 @@ export interface IChatAgentRequest {
 	rejectedConfirmationData?: any[];
 	userSelectedModelId?: string;
 	userSelectedTools?: Record<string, boolean>;
+	modeInstructions?: string;
 	toolSelectionIsExclusive?: boolean;
 	editedFileEvents?: IChatAgentEditedFileEvent[];
 }

src/vs/workbench/contrib/chat/common/chatModes.ts

@@ -62,12 +62,16 @@ export class ChatModeService implements IChatModeService {
 	}
 }
 
+/**
+ * TODO This data object is not quite the right pattern, needs to live-update on file changes
+ */
 export interface IChatMode {
 	readonly id: string;
 	readonly name: string;
 	readonly description?: string;
 	readonly kind: ChatMode;
 	readonly customTools?: readonly string[];
+	readonly body?: string;
 }
 
 export function isIChatMode(mode: unknown): mode is IChatMode {
@@ -97,6 +101,10 @@ export class CustomChatMode implements IChatMode {
 		return this.customChatMode.tools;
 	}
 
+	get body(): string {
+		return this.customChatMode.body;
+	}
+
 	public readonly kind = ChatMode.Agent;
 
 	constructor(
@@ -112,7 +120,8 @@ export class CustomChatMode implements IChatMode {
 			name: this.name,
 			description: this.description,
 			kind: this.kind,
-			customTools: this.customTools
+			customTools: this.customTools,
+			body: this.body
 		};
 	}
 }

src/vs/workbench/contrib/chat/common/chatService.ts

@@ -488,6 +488,7 @@ export interface IChatSendRequestOptions {
 	mode?: ChatMode;
 	userSelectedModelId?: string;
 	userSelectedTools?: Record<string, boolean>;
+	modeInstructions?: string;
 	toolSelectionIsExclusive?: boolean;
 	location?: ChatAgentLocation;
 	locationData?: IChatLocationData;

src/vs/workbench/contrib/chat/common/chatServiceImpl.ts

@@ -763,6 +763,7 @@ export class ChatService extends Disposable implements IChatService {
 							rejectedConfirmationData: options?.rejectedConfirmationData,
 							userSelectedModelId: options?.userSelectedModelId,
 							userSelectedTools: options?.userSelectedTools,
+							modeInstructions: options?.modeInstructions,
 							toolSelectionIsExclusive: options?.toolSelectionIsExclusive,
 							editedFileEvents: request.editedFileEvents
 						} satisfies IChatAgentRequest;

src/vscode-dts/vscode.proposed.chatParticipantAdditions.d.ts

@@ -446,4 +446,8 @@ declare module 'vscode' {
 	export interface LanguageModelToolInvocationOptions<T> {
 		model?: LanguageModelChat;
 	}
+
+	export interface ChatRequest {
+		modeInstructions?: string;
+	}
 }