Merge pull request microsoft#191519 from microsoft/merogge/tab-shift

rm `Shift+tab` as keybinding for opening terminal accessible buffer

Author: meganrogge

src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts

@@ -116,8 +116,8 @@ registerTerminalAction({
 	precondition: ContextKeyExpr.or(TerminalContextKeys.processSupported, TerminalContextKeys.terminalHasBeenCreated),
 	keybinding: [
 		{
-			primary: KeyMod.Shift | KeyCode.Tab,
-			secondary: [KeyMod.CtrlCmd | KeyCode.UpArrow, KeyMod.Alt | KeyCode.F2],
+			primary: KeyMod.Alt | KeyCode.F2,
+			secondary: [KeyMod.CtrlCmd | KeyCode.UpArrow],
 			weight: KeybindingWeight.WorkbenchContrib,
 			when: ContextKeyExpr.and(CONTEXT_ACCESSIBILITY_MODE_ENABLED, TerminalContextKeys.focus, ContextKeyExpr.or(terminalTabFocusModeContextKey, TerminalContextKeys.accessibleBufferFocus.negate()))
 		}

src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts

@@ -62,18 +62,6 @@ export class AccessibleBufferWidget extends TerminalAccessibleWidget {
 		this.element.ariaRoleDescription = localize('terminal.integrated.accessibleBuffer', 'Terminal buffer');
 		_instance.onDidRequestFocus(() => this.hide(true));
 		this.updateEditor();
-		this.add(this.editorWidget.onDidFocusEditorText(async () => {
-			if (this.element.classList.contains(ClassName.Active)) {
-				// the user has focused the editor via mouse or
-				// Go to Command was run so we've already updated the editor
-				return;
-			}
-			// if the editor is focused via tab, we need to update the model
-			// and show it
-			this.registerListeners();
-			await this.updateEditor();
-			this.element.classList.add(ClassName.Active);
-		}));
 		// xterm's initial layout call has already happened
 		this.layout();
 	}