Skip to content

Commit 7b2cc73

Browse files
authored
debug: fix call stack dropdown menu hidden (microsoft#209042)
Fixes microsoft#208817
1 parent 80ca971 commit 7b2cc73

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/vs/platform/actions/browser/dropdownWithPrimaryActionViewItem.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ export interface IDropdownWithPrimaryActionViewItemOptions {
2525
actionRunner?: IActionRunner;
2626
getKeyBinding?: (action: IAction) => ResolvedKeybinding | undefined;
2727
hoverDelegate?: IHoverDelegate;
28+
menuAsChild?: boolean;
2829
}
2930

3031
export class DropdownWithPrimaryActionViewItem extends BaseActionViewItem {
@@ -57,7 +58,7 @@ export class DropdownWithPrimaryActionViewItem extends BaseActionViewItem {
5758
}
5859

5960
this._dropdown = new DropdownMenuActionViewItem(dropdownAction, dropdownMenuActions, this._contextMenuProvider, {
60-
menuAsChild: true,
61+
menuAsChild: _options?.menuAsChild ?? true,
6162
classNames: className ? ['codicon', 'codicon-chevron-down', className] : ['codicon', 'codicon-chevron-down'],
6263
actionRunner: this._options?.actionRunner,
6364
keybindingProvider: this._options?.getKeyBinding,

src/vs/workbench/contrib/debug/browser/callStackView.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -550,7 +550,7 @@ class SessionsRenderer implements ICompressibleTreeRenderer<IDebugSession, Fuzzy
550550
actionViewItemProvider: (action, options) => {
551551
if ((action.id === STOP_ID || action.id === DISCONNECT_ID) && action instanceof MenuItemAction) {
552552
stopActionViewItemDisposables.clear();
553-
const item = this.instantiationService.invokeFunction(accessor => createDisconnectMenuItemAction(action as MenuItemAction, stopActionViewItemDisposables, accessor, options));
553+
const item = this.instantiationService.invokeFunction(accessor => createDisconnectMenuItemAction(action as MenuItemAction, stopActionViewItemDisposables, accessor, { ...options, menuAsChild: false }));
554554
if (item) {
555555
return item;
556556
}

0 commit comments

Comments
 (0)