Skip to content

Commit 7c1bff3

Browse files
authored
Merge pull request microsoft#196966 from microsoft/sandy081/fascinating-partridge
fix microsoft#196801
2 parents 48c0280 + 70ee845 commit 7c1bff3

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/vs/workbench/services/activity/browser/activityService.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import { IViewDescriptorService, ViewContainer } from 'vs/workbench/common/views
1010
import { GLOBAL_ACTIVITY_ID, ACCOUNTS_ACTIVITY_ID } from 'vs/workbench/common/activity';
1111
import { Emitter, Event } from 'vs/base/common/event';
1212
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
13+
import { isUndefined } from 'vs/base/common/types';
1314

1415
class ViewContainerActivityByView extends Disposable {
1516

@@ -82,10 +83,10 @@ export class ActivityService extends Disposable implements IActivityService {
8283
this.viewContainerActivities.set(viewContainerId, activities);
8384
}
8485
for (let i = 0; i <= activities.length; i++) {
85-
if (i === activities.length) {
86+
if (i === activities.length || isUndefined(activity.priority)) {
8687
activities.push(activity);
8788
break;
88-
} else if (activities[i].priority ?? 0 <= (activity.priority ?? 0)) {
89+
} else if (isUndefined(activities[i].priority) || activities[i].priority! <= activity.priority) {
8990
activities.splice(i, 0, activity);
9091
break;
9192
}

0 commit comments

Comments
 (0)