Skip to content

Commit 7cee428

Browse files
authored
Larger default nb find widget size + in selection label verbage (microsoft#216847)
Larger default nb find widget size + selection label verbage
1 parent 05e6e67 commit 7cee428

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/vs/workbench/contrib/notebook/browser/contrib/find/notebookFindReplaceWidget.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,8 @@ import { ICellRange } from 'vs/workbench/contrib/notebook/common/notebookRange';
4949
const NLS_FIND_INPUT_LABEL = nls.localize('label.find', "Find");
5050
const NLS_FIND_INPUT_PLACEHOLDER = nls.localize('placeholder.find', "Find");
5151
const NLS_PREVIOUS_MATCH_BTN_LABEL = nls.localize('label.previousMatchButton', "Previous Match");
52-
// const NLS_FILTER_BTN_LABEL = nls.localize('label.findFilterButton', "Search in View");
5352
const NLS_NEXT_MATCH_BTN_LABEL = nls.localize('label.nextMatchButton', "Next Match");
54-
const NLS_FIND_IN_CELL_SELECTION_BTN_LABEL = nls.localize('label.findInCellSelectionButton', "Find in Cell Selection");
53+
const NLS_TOGGLE_SELECTION_FIND_TITLE = nls.localize('label.toggleSelectionFind', "Find in Selection");
5554
const NLS_CLOSE_BTN_LABEL = nls.localize('label.closeButton', "Close");
5655
const NLS_TOGGLE_REPLACE_MODE_BTN_LABEL = nls.localize('label.toggleReplaceButton', "Toggle Replace");
5756
const NLS_REPLACE_INPUT_LABEL = nls.localize('label.replace', "Replace");
@@ -66,7 +65,7 @@ const NOTEBOOK_FIND_IN_MARKUP_PREVIEW = nls.localize('notebook.find.filter.findI
6665
const NOTEBOOK_FIND_IN_CODE_INPUT = nls.localize('notebook.find.filter.findInCodeInput', "Code Cell Source");
6766
const NOTEBOOK_FIND_IN_CODE_OUTPUT = nls.localize('notebook.find.filter.findInCodeOutput', "Code Cell Output");
6867

69-
const NOTEBOOK_FIND_WIDGET_INITIAL_WIDTH = 318;
68+
const NOTEBOOK_FIND_WIDGET_INITIAL_WIDTH = 419;
7069
const NOTEBOOK_FIND_WIDGET_INITIAL_HORIZONTAL_PADDING = 4;
7170
class NotebookFindFilterActionViewItem extends DropdownMenuActionViewItem {
7271
constructor(readonly filters: NotebookFindFilters, action: IAction, options: IActionViewItemOptions, actionRunner: IActionRunner, @IContextMenuService contextMenuService: IContextMenuService) {
@@ -386,6 +385,7 @@ export abstract class SimpleFindReplaceWidget extends Widget {
386385
null,
387386
this._contextViewService,
388387
{
388+
// width:FIND_INPUT_AREA_WIDTH,
389389
label: NLS_FIND_INPUT_LABEL,
390390
placeholder: NLS_FIND_INPUT_PLACEHOLDER,
391391
validation: (value: string): InputBoxMessage | null => {
@@ -462,7 +462,7 @@ export abstract class SimpleFindReplaceWidget extends Widget {
462462

463463
this.inSelectionToggle = this._register(new Toggle({
464464
icon: findSelectionIcon,
465-
title: NLS_FIND_IN_CELL_SELECTION_BTN_LABEL,
465+
title: NLS_TOGGLE_SELECTION_FIND_TITLE,
466466
isChecked: false,
467467
inputActiveOptionBackground: asCssVariable(inputActiveOptionBackground),
468468
inputActiveOptionBorder: asCssVariable(inputActiveOptionBorder),

0 commit comments

Comments
 (0)