update task handling in ChatStickyTaskWidget and ChatWidget (microsoft#257942)

Author: bhavyaus

src/vs/workbench/contrib/chat/browser/chatContentParts/chatStickyTaskWidget.ts

@@ -7,7 +7,7 @@ import * as dom from '../../../../../base/browser/dom.js';
 import { Emitter, Event } from '../../../../../base/common/event.js';
 import { Disposable } from '../../../../../base/common/lifecycle.js';
 import { localize } from '../../../../../nls.js';
-import { IChatTasksContent } from '../../common/chatService.js';
+import { IChatTasksService, IChatTask } from '../../common/chatTasksService.js';
 
 export class ChatStickyTaskWidget extends Disposable {
 	public readonly domNode: HTMLElement;
@@ -18,9 +18,11 @@ export class ChatStickyTaskWidget extends Disposable {
 	private _isExpanded: boolean = true;
 	private expandoElement!: HTMLElement;
 	private taskListContainer!: HTMLElement;
-	private _taskData: IChatTasksContent | undefined;
+	private _currentSessionId: string | undefined;
 
-	constructor() {
+	constructor(
+		@IChatTasksService private readonly chatTasksService: IChatTasksService
+	) {
 		super();
 
 		this.domNode = this.createStickyTaskWidget();
@@ -68,11 +70,23 @@ export class ChatStickyTaskWidget extends Disposable {
 		return container;
 	}
 
-	public updateTaskData(taskData: IChatTasksContent | undefined): void {
-		this._taskData = taskData;
+	public updateSessionId(sessionId: string | undefined): void {
+		this._currentSessionId = sessionId;
+		this.updateTaskDisplay();
+	}
+
+	private updateTaskDisplay(): void {
+		if (!this._currentSessionId) {
+			this.domNode.style.display = 'none';
+			this._onDidChangeHeight.fire();
+			return;
+		}
 
-		if (taskData && taskData.tasks.length > 0) {
-			this.renderTaskList();
+		const taskStorage = this.chatTasksService.getChatTasksStorage();
+		const tasks = taskStorage.getTasks(this._currentSessionId);
+
+		if (tasks.length > 0) {
+			this.renderTaskList(tasks);
 			this.domNode.style.display = 'block';
 		} else {
 			this.domNode.style.display = 'none';
@@ -81,19 +95,15 @@ export class ChatStickyTaskWidget extends Disposable {
 		this._onDidChangeHeight.fire();
 	}
 
-	private renderTaskList(): void {
-		if (!this._taskData || !this._taskData.tasks.length) {
-			return;
-		}
-
+	private renderTaskList(tasks: IChatTask[]): void {
 		this.taskListContainer.textContent = '';
 
 		const titleElement = this.expandoElement.querySelector('.task-title') as HTMLElement;
 		if (titleElement) {
 			titleElement.textContent = `${localize('chat.task.title', 'Tasks')}`;
 		}
 
-		this._taskData.tasks.forEach((task, index) => {
+		tasks.forEach((task, index) => {
 			const taskElement = dom.$('.task-item');
 
 			const statusIcon = dom.$('.task-status-icon.codicon');

src/vs/workbench/contrib/chat/browser/chatWidget.ts

@@ -45,7 +45,7 @@ import { applyingChatEditsFailedContextKey, decidedChatEditingResourceContextKey
 import { ChatPauseState, IChatModel, IChatResponseModel } from '../common/chatModel.js';
 import { chatAgentLeader, ChatRequestAgentPart, ChatRequestDynamicVariablePart, ChatRequestSlashPromptPart, ChatRequestToolPart, ChatRequestToolSetPart, chatSubcommandLeader, formatChatQuestion, IParsedChatRequest } from '../common/chatParserTypes.js';
 import { ChatRequestParser } from '../common/chatRequestParser.js';
-import { IChatLocationData, IChatSendRequestOptions, IChatService, IChatTasksContent } from '../common/chatService.js';
+import { IChatLocationData, IChatSendRequestOptions, IChatService } from '../common/chatService.js';
 import { IChatSlashCommandService } from '../common/chatSlashCommands.js';
 import { ChatViewModel, IChatRequestViewModel, IChatResponseViewModel, isRequestVM, isResponseVM } from '../common/chatViewModel.js';
 import { IChatInputState } from '../common/chatWidgetHistoryService.js';
@@ -68,13 +68,13 @@ import { ChatViewWelcomePart, IChatSuggestedPrompts, IChatViewWelcomeContent } f
 import { MicrotaskDelay } from '../../../../base/common/symbols.js';
 import { IChatRequestVariableEntry, ChatRequestVariableSet as ChatRequestVariableSet, isPromptFileVariableEntry, toPromptFileVariableEntry, PromptFileVariableKind, isPromptTextVariableEntry } from '../common/chatVariableEntries.js';
 import { ChatStickyTaskWidget } from './chatContentParts/chatStickyTaskWidget.js';
-import { ManageToolSettingId } from '../common/tools/manageTasksTool.js';
 import { PromptsConfig } from '../common/promptSyntax/config/config.js';
 import { CancellationToken } from '../../../../base/common/cancellation.js';
 import { ComputeAutomaticInstructions } from '../common/promptSyntax/computeAutomaticInstructions.js';
 import { startupExpContext, StartupExperimentGroup } from '../../../services/coreExperimentation/common/coreExperimentationService.js';
 import { IWorkspaceContextService, WorkbenchState } from '../../../../platform/workspace/common/workspace.js';
 import { IMouseWheelEvent } from '../../../../base/browser/mouseEvent.js';
+import { ManageToolSettingId } from '../common/tools/manageTasksTool.js';
 
 const $ = dom.$;
 
@@ -829,27 +829,9 @@ export class ChatWidget extends Disposable implements IChatWidget {
 
 	private renderStickyTaskWidget(): void {
 		const isManageTasksToolEnabled = this.configurationService.getValue<boolean>(ManageToolSettingId) === true;
-		if (!this.viewModel || !isManageTasksToolEnabled) {
-			this.stickyTaskWidget.updateTaskData(undefined);
-			return;
-		}
-
-		let latestTaskData: IChatTasksContent | undefined;
-		for (const item of this.viewModel.getItems().slice().reverse()) {
-			if (isResponseVM(item)) {
-				for (const content of item.response.value) {
-					if (content.kind === 'toolInvocation' &&
-						content.toolSpecificData?.kind === 'tasks') {
-						latestTaskData = content.toolSpecificData;
-						break;
-					}
-				}
-				if (latestTaskData) {
-					break;
-				}
-			}
+		if (isManageTasksToolEnabled) {
+			this.stickyTaskWidget.updateSessionId(this.viewModel?.sessionId);
 		}
-		this.stickyTaskWidget.updateTaskData(latestTaskData);
 	}
 
 	private getWelcomeViewContent(additionalMessage: string | IMarkdownString | undefined, expEmptyState?: boolean): IChatViewWelcomeContent {