Clean up

Author: Tyriar

src/vs/platform/terminal/common/terminal.ts

@@ -207,7 +207,9 @@ export enum TerminalIpcChannels {
 	 * Communicates between the shared process and the pty host process.
 	 */
 	PtyHost = 'ptyHost',
-
+	/**
+	 * Communicates between the renderer process and the pty host process.
+	 */
 	PtyHostWindow = 'ptyHostWindow',
 	/**
 	 * Deals with logging from the pty host process.

src/vs/platform/terminal/node/ptyHostService.ts

@@ -36,10 +36,9 @@ let lastPtyId = 0;
 export class PtyHostService extends Disposable implements IPtyService {
 	declare readonly _serviceBrand: undefined;
 
-	// TODO: Avoid ! ?
-	private _connection!: IPtyHostConnection;
+	private _connection: IPtyHostConnection;
 	// ProxyChannel is not used here because events get lost when forwarding across multiple proxies
-	private _proxy!: IPtyService;
+	private _proxy: IPtyService;
 
 	private readonly _shellEnv: Promise<typeof process.env>;
 	private readonly _resolveVariablesRequestStore: RequestStore<string[], { workspaceId: string; originalText: string[] }>;

src/vs/workbench/contrib/terminal/electron-sandbox/localTerminalBackend.ts

@@ -65,7 +65,6 @@ class LocalTerminalBackend extends BaseTerminalBackend implements ITerminalBacke
 		@IShellEnvironmentService private readonly _shellEnvironmentService: IShellEnvironmentService,
 		@IStorageService private readonly _storageService: IStorageService,
 		@IConfigurationResolverService private readonly _configurationResolverService: IConfigurationResolverService,
-		@IConfigurationService configurationService: IConfigurationService,
 		@IConfigurationService private readonly _configurationService: IConfigurationService,
 		@IProductService private readonly _productService: IProductService,
 		@IHistoryService private readonly _historyService: IHistoryService,
@@ -93,12 +92,6 @@ class LocalTerminalBackend extends BaseTerminalBackend implements ITerminalBacke
 		const client = new MessagePortClient(port, `window:${this._environmentService.window.id}`);
 		this._ptyHostDirectProxy = ProxyChannel.toService<IPtyService>(client.getChannel(TerminalIpcChannels.PtyHostWindow));
 
-		// Testing
-		// this._logService.info('latency: ', this._ptyHostDirectProxy.getLatency(0));
-		// this._ptyHostDirectProxy.onProcessData(e => {
-		// 	this._logService.info('message port process data: ' + e.event);
-		// });
-
 		// Attach process listeners
 		this._ptyHostDirectProxy!.onProcessData(e => this._ptys.get(e.id)?.handleData(e.event));
 		this._ptyHostDirectProxy!.onDidChangeProperty(e => this._ptys.get(e.id)?.handleDidChangeProperty(e.property));