Skip to content

Commit 7f9be88

Browse files
authored
POINTER_DOWN was stealing too many events. The old event handlers handled events such as MOUSE_UP, and it turns out we can just use POINTER_UP instead.
1 parent a4e0d1f commit 7f9be88

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/vs/base/browser/ui/selectBox/selectBoxCustom.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -777,8 +777,7 @@ export class SelectBoxList extends Disposable implements ISelectBoxDelegate, ILi
777777
this._register(onSelectDropDownKeyDown.filter(e => (e.keyCode >= KeyCode.Digit0 && e.keyCode <= KeyCode.KeyZ) || (e.keyCode >= KeyCode.Semicolon && e.keyCode <= KeyCode.NumpadDivide)).on(this.onCharacter, this));
778778

779779
// SetUp list mouse controller - control navigation, disabled items, focus
780-
781-
this._register(dom.addDisposableListener(this.selectList.getHTMLElement(), dom.EventType.POINTER_DOWN, e => this.onPointerDown(e)));
780+
this._register(dom.addDisposableListener(this.selectList.getHTMLElement(), dom.EventType.POINTER_UP, e => this.onPointerUp(e)));
782781

783782
this._register(this.selectList.onMouseOver(e => typeof e.index !== 'undefined' && this.selectList.setFocus([e.index])));
784783
this._register(this.selectList.onDidChangeFocus(e => this.onListFocus(e)));
@@ -800,7 +799,7 @@ export class SelectBoxList extends Disposable implements ISelectBoxDelegate, ILi
800799

801800
// List mouse controller - active exit, select option, fire onDidSelect if change, return focus to parent select
802801
// Also takes in touchend events
803-
private onPointerDown(e: PointerEvent): void {
802+
private onPointerUp(e: PointerEvent): void {
804803

805804
if (!this.selectList.length) {
806805
return;
@@ -814,7 +813,7 @@ export class SelectBoxList extends Disposable implements ISelectBoxDelegate, ILi
814813
}
815814

816815
// Check our mouse event is on an option (not scrollbar)
817-
if (!!target.classList.contains('slider')) {
816+
if (target.classList.contains('slider')) {
818817
return;
819818
}
820819

0 commit comments

Comments
 (0)