Skip to content

Commit 7fa7d08

Browse files
committed
1 parent 3be6ca6 commit 7fa7d08

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

src/vs/workbench/contrib/terminal/browser/terminalActions.ts

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -811,8 +811,12 @@ export function registerTerminalActions() {
811811
title: terminalStrings.changeIcon,
812812
f1: false,
813813
precondition: sharedWhenClause.terminalAvailable_and_singularSelection,
814-
run: async (c, accessor) => {
814+
run: async (c, accessor, args) => {
815815
let icon: TerminalIcon | undefined;
816+
if (c.groupService.lastAccessedMenu === 'inline-tab') {
817+
getResourceOrActiveInstance(c, args)?.changeIcon();
818+
return;
819+
}
816820
for (const terminal of getSelectedInstances(accessor) ?? []) {
817821
icon = await terminal.changeIcon(icon);
818822
}
@@ -831,9 +835,13 @@ export function registerTerminalActions() {
831835
title: terminalStrings.changeColor,
832836
f1: false,
833837
precondition: sharedWhenClause.terminalAvailable_and_singularSelection,
834-
run: async (c, accessor) => {
838+
run: async (c, accessor, args) => {
835839
let color: string | undefined;
836840
let i = 0;
841+
if (c.groupService.lastAccessedMenu === 'inline-tab') {
842+
getResourceOrActiveInstance(c, args)?.changeColor();
843+
return;
844+
}
837845
for (const terminal of getSelectedInstances(accessor) ?? []) {
838846
const skipQuickPick = i !== 0;
839847
// Always show the quickpick on the first iteration
@@ -1726,7 +1734,7 @@ function getSelectedInstances(accessor: ServicesAccessor, args?: unknown, args2?
17261734
for (const selection of selections) {
17271735
result.push(terminalService.getInstanceFromIndex(selection) as ITerminalInstance);
17281736
}
1729-
return result;
1737+
return result.filter(r => !!r);
17301738
}
17311739

17321740
export function validateTerminalName(name: string): { content: string; severity: Severity } | null {

0 commit comments

Comments
 (0)