Skip to content

Commit 81e1ca0

Browse files
committed
cleaning the code
1 parent 1f3bd32 commit 81e1ca0

File tree

3 files changed

+5
-14
lines changed

3 files changed

+5
-14
lines changed

src/vs/workbench/browser/parts/editor/editorsObserver.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -430,24 +430,19 @@ export class EditorsObserver extends Disposable {
430430
entries: coalesce(entries.map(({ editor, groupId }) => {
431431

432432
// Find group for entry
433-
console.log('editor: ', editor);
434-
console.log('groupId : ', groupId);
435433
const group = this.editorGroupsContainer.getGroup(groupId);
436-
console.log('group : ', group);
437434
if (!group) {
438435
return undefined;
439436
}
440437

441438
// Find serializable editors of group
442439
let serializableEditorsOfGroup = mapGroupToSerializableEditorsOfGroup.get(group);
443-
console.log('serializableEditorsOfGroup : ', serializableEditorsOfGroup);
444440
if (!serializableEditorsOfGroup) {
445441
serializableEditorsOfGroup = group.getEditors(EditorsOrder.SEQUENTIAL).filter(editor => {
446442
const editorSerializer = registry.getEditorSerializer(editor);
447443

448444
return editorSerializer?.canSerialize(editor);
449445
});
450-
console.log('serializableEditorsOfGroup : ', serializableEditorsOfGroup);
451446
mapGroupToSerializableEditorsOfGroup.set(group, serializableEditorsOfGroup);
452447
}
453448

src/vs/workbench/common/editor/editorGroupModel.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1032,10 +1032,9 @@ export class EditorGroupModel extends Disposable implements IEditorGroupModel {
10321032
let canSerializeEditor = false;
10331033

10341034
const editorSerializer = registry.getEditorSerializer(editor);
1035-
if (editorSerializer && editorSerializer.canSerialize(editor)) {
1035+
if (editorSerializer) {
10361036
const value = editorSerializer.serialize(editor);
10371037

1038-
console.log('value : ', value);
10391038
// Editor can be serialized
10401039
if (typeof value === 'string') {
10411040
canSerializeEditor = true;

src/vs/workbench/contrib/multiDiffEditor/browser/multiDiffEditorInput.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ export class MultiDiffEditorInput extends EditorInput implements ILanguageSuppor
5353
}
5454

5555
public static fromSerialized(data: ISerializedMultiDiffEditorInput, instantiationService: IInstantiationService): MultiDiffEditorInput {
56-
console.log('inside of fromSerialized');
5756
return instantiationService.createInstance(
5857
MultiDiffEditorInput,
5958
URI.parse(data.multiDiffSourceUri),
@@ -90,7 +89,6 @@ export class MultiDiffEditorInput extends EditorInput implements ILanguageSuppor
9089
@IMultiDiffSourceResolverService private readonly _multiDiffSourceResolverService: IMultiDiffSourceResolverService,
9190
@ITextFileService private readonly _textFileService: ITextFileService,
9291
) {
93-
console.log('isTransient from the constructor : ', isTransient);
9492
super();
9593

9694
this._register(autorun((reader) => {
@@ -365,19 +363,18 @@ interface ISerializedMultiDiffEditorInput {
365363
}
366364

367365
export class MultiDiffEditorSerializer implements IEditorSerializer {
366+
367+
// TODO@bpasero, @aiday-mar: following should be removed
368368
canSerialize(editor: EditorInput): boolean {
369-
console.log('inside of can serialize');
370-
console.log('editor instanceof MultiDiffEditorInput && !editor.isTransient : ', editor instanceof MultiDiffEditorInput && !editor.isTransient);
371369
return editor instanceof MultiDiffEditorInput && !editor.isTransient;
372370
}
373371

374372
serialize(editor: MultiDiffEditorInput): string | undefined {
375-
console.log('inside of serialize');
376-
return JSON.stringify(editor.serialize());
373+
const shouldSerialize = editor instanceof MultiDiffEditorInput && !editor.isTransient;
374+
return shouldSerialize ? JSON.stringify(editor.serialize()) : undefined;
377375
}
378376

379377
deserialize(instantiationService: IInstantiationService, serializedEditor: string): EditorInput | undefined {
380-
console.log('inside of deserialize');
381378
try {
382379
const data = parse(serializedEditor) as ISerializedMultiDiffEditorInput;
383380
return MultiDiffEditorInput.fromSerialized(data, instantiationService);

0 commit comments

Comments
 (0)