Skip to content

Commit 82c58f9

Browse files
authored
Merge pull request microsoft#185718 from weartist/mainss
Fix:microsoft#185359
2 parents 48ff3ff + 3c0ea33 commit 82c58f9

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* Licensed under the MIT License. See License.txt in the project root for license information.
44
*--------------------------------------------------------------------------------------------*/
55

6+
import { asArray } from 'vs/base/common/arrays';
67
import * as Async from 'vs/base/common/async';
78
import { IStringDictionary } from 'vs/base/common/collections';
89
import { Emitter, Event } from 'vs/base/common/event';
@@ -16,7 +17,6 @@ import * as resources from 'vs/base/common/resources';
1617
import Severity from 'vs/base/common/severity';
1718
import * as Types from 'vs/base/common/types';
1819
import * as nls from 'vs/nls';
19-
import { asArray } from 'vs/base/common/arrays';
2020

2121
import { IModelService } from 'vs/editor/common/services/model';
2222
import { IFileService } from 'vs/platform/files/common/files';
@@ -27,18 +27,19 @@ import { ProblemMatcher, ProblemMatcherRegistry /*, ProblemPattern, getResource
2727

2828
import { Codicon } from 'vs/base/common/codicons';
2929
import { Schemas } from 'vs/base/common/network';
30+
import { ThemeIcon } from 'vs/base/common/themables';
3031
import { URI } from 'vs/base/common/uri';
32+
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
3133
import { ILogService } from 'vs/platform/log/common/log';
3234
import { INotificationService } from 'vs/platform/notification/common/notification';
3335
import { IShellLaunchConfig, WaitOnExitValue } from 'vs/platform/terminal/common/terminal';
3436
import { formatMessageForTerminal } from 'vs/platform/terminal/common/terminalStrings';
35-
import { ThemeIcon } from 'vs/base/common/themables';
3637
import { IViewDescriptorService, IViewsService, ViewContainerLocation } from 'vs/workbench/common/views';
3738
import { TaskTerminalStatus } from 'vs/workbench/contrib/tasks/browser/taskTerminalStatus';
3839
import { ProblemCollectorEventKind, ProblemHandlingStrategy, StartStopProblemCollector, WatchingProblemCollector } from 'vs/workbench/contrib/tasks/common/problemCollectors';
3940
import { GroupKind } from 'vs/workbench/contrib/tasks/common/taskConfiguration';
40-
import { CommandOptions, CommandString, ContributedTask, CustomTask, DependsOrder, ICommandConfiguration, IConfigurationProperties, IExtensionTaskSource, InMemoryTask, IPresentationOptions, IShellConfiguration, IShellQuotingOptions, ITaskEvent, PanelKind, RevealKind, RevealProblemKind, RuntimeType, ShellQuoting, Task, TaskEvent, TaskEventKind, TaskScope, TaskSourceKind } from 'vs/workbench/contrib/tasks/common/tasks';
41-
import { IResolvedVariables, IResolveSet, ITaskExecuteResult, ITaskResolver, ITaskSummary, ITaskSystem, ITaskSystemInfo, ITaskSystemInfoResolver, ITaskTerminateResponse, TaskError, TaskErrors, TaskExecuteKind, Triggers } from 'vs/workbench/contrib/tasks/common/taskSystem';
41+
import { IResolveSet, IResolvedVariables, ITaskExecuteResult, ITaskResolver, ITaskSummary, ITaskSystem, ITaskSystemInfo, ITaskSystemInfoResolver, ITaskTerminateResponse, TaskError, TaskErrors, TaskExecuteKind, Triggers } from 'vs/workbench/contrib/tasks/common/taskSystem';
42+
import { CommandOptions, CommandString, ContributedTask, CustomTask, DependsOrder, ICommandConfiguration, IConfigurationProperties, IExtensionTaskSource, IPresentationOptions, IShellConfiguration, IShellQuotingOptions, ITaskEvent, InMemoryTask, PanelKind, RevealKind, RevealProblemKind, RuntimeType, ShellQuoting, Task, TaskEvent, TaskEventKind, TaskScope, TaskSourceKind } from 'vs/workbench/contrib/tasks/common/tasks';
4243
import { ITerminalGroupService, ITerminalInstance, ITerminalService } from 'vs/workbench/contrib/terminal/browser/terminal';
4344
import { VSCodeOscProperty, VSCodeOscPt, VSCodeSequence } from 'vs/workbench/contrib/terminal/browser/terminalEscapeSequences';
4445
import { TerminalProcessExtHostProxy } from 'vs/workbench/contrib/terminal/browser/terminalProcessExtHostProxy';
@@ -48,7 +49,6 @@ import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/
4849
import { IOutputService } from 'vs/workbench/services/output/common/output';
4950
import { IPaneCompositePartService } from 'vs/workbench/services/panecomposite/browser/panecomposite';
5051
import { IPathService } from 'vs/workbench/services/path/common/pathService';
51-
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
5252
import { IDisposable } from 'xterm';
5353

5454
interface ITerminalData {
@@ -1037,7 +1037,7 @@ export class TerminalTaskSystem extends Disposable implements ITaskSystem {
10371037
const showProblemPanel = task.command.presentation && (task.command.presentation.revealProblems === RevealProblemKind.Always);
10381038
if (showProblemPanel) {
10391039
this._viewsService.openView(Markers.MARKERS_VIEW_ID);
1040-
} else if (task.command.presentation && (task.command.presentation.reveal === RevealKind.Always)) {
1040+
} else if (task.command.presentation && (task.command.presentation.focus || task.command.presentation.reveal === RevealKind.Always)) {
10411041
this._terminalService.setActiveInstance(terminal);
10421042
this._terminalGroupService.showPanel(task.command.presentation.focus);
10431043
}

0 commit comments

Comments
 (0)