small fix in logic

Michael Lively · Michael Lively · commit 834ad7365b97 · 2022-08-31T15:41:15.000-07:00
diff --git a/extensions/ipynb/src/notebookImagePaste.ts b/extensions/ipynb/src/notebookImagePaste.ts
@@ -135,7 +135,9 @@ function buildAttachment(b64: string, cell: vscode.NotebookCell, filename: strin
 			const objEntries = Object.entries(startingAttachments[tempFilename]);
 			if (objEntries.length) { // check that mime:b64 are present
 				const [, attachmentb64] = objEntries[0];
-				if (attachmentb64 !== b64) {	// append a "-#" here. same name, diff data. this matches jupyter behavior
+				if (attachmentb64 === b64) { // checking if filename can be reused, based on camparison of image data
+					break;
+				} else {
 					tempFilename = filename.concat(`-${appendValue}`) + filetype;
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,9 @@ function buildAttachment(b64: string, cell: vscode.NotebookCell, filename: strin`
`135`	`135`	`const objEntries = Object.entries(startingAttachments[tempFilename]);`
`136`	`136`	`if (objEntries.length) { // check that mime:b64 are present`
`137`	`137`	`const [, attachmentb64] = objEntries[0];`
`138`		`- if (attachmentb64 !== b64) { // append a "-#" here. same name, diff data. this matches jupyter behavior`
	`138`	`+ if (attachmentb64 === b64) { // checking if filename can be reused, based on camparison of image data`
	`139`	`+ break;`
	`140`	`+ } else {`
`139`	`141`	tempFilename = filename.concat(`-${appendValue}`) + filetype;
`140`	`142`	`}`
`141`	`143`	`}`