Skip to content

Commit 8515f91

Browse files
authored
task reconnection polish (microsoft#158774)
fix microsoft#158770 && fix microsoft#158676
1 parent 650669a commit 8515f91

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1302,7 +1302,7 @@ export class TerminalTaskSystem extends Disposable implements ITaskSystem {
13021302
reconnectedTerminal.waitOnExit = getWaitOnExitValue(task.command.presentation, task.configurationProperties);
13031303
}
13041304
reconnectedTerminal.onDisposed((terminal) => this._fireTaskEvent({ kind: TaskEventKind.Terminated, exitReason: terminal.exitReason, taskId: task.getRecentlyUsedKey() }));
1305-
this._logService.info('reconnected to task and terminal', task._id);
1305+
this._logService.trace('reconnected to task and terminal', task._id);
13061306
return reconnectedTerminal;
13071307
}
13081308
if (group) {
@@ -1330,20 +1330,20 @@ export class TerminalTaskSystem extends Disposable implements ITaskSystem {
13301330

13311331
private _reconnectToTerminals(): void {
13321332
if (this._hasReconnected) {
1333-
this._logService.info(`Already reconnected, to ${this._reconnectedTerminals?.length} terminals so returning`);
1333+
this._logService.trace(`Already reconnected, to ${this._reconnectedTerminals?.length} terminals so returning`);
13341334
return;
13351335
}
13361336
this._reconnectedTerminals = this._terminalService.getReconnectedTerminals(ReconnectionType)?.filter(t => !t.isDisposed);
1337-
this._logService.info(`Attempting reconnection of ${this._reconnectedTerminals?.length} terminals`);
1337+
this._logService.trace(`Attempting reconnection of ${this._reconnectedTerminals?.length} terminals`);
13381338
if (!this._reconnectedTerminals?.length) {
1339-
this._logService.info(`No terminals to reconnect to so returning`);
1339+
this._logService.trace(`No terminals to reconnect to so returning`);
13401340
this._hasReconnected = true;
13411341
return;
13421342
} else {
13431343
for (const terminal of this._reconnectedTerminals) {
13441344
const task = terminal.shellLaunchConfig.attachPersistentProcess?.reconnectionProperties?.data as IReconnectionTaskData;
13451345
if (this._logService.getLevel() <= LogLevel.Trace) {
1346-
this._logService.info(`Reconnecting to task: ${JSON.stringify(task)}`);
1346+
this._logService.trace(`Reconnecting to task: ${JSON.stringify(task)}`);
13471347
}
13481348
if (!task) {
13491349
continue;

src/vs/workbench/contrib/tasks/common/tasks.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1205,7 +1205,7 @@ export const enum TaskSettingId {
12051205
QuickOpenSkip = 'task.quickOpen.skip',
12061206
QuickOpenShowAll = 'task.quickOpen.showAll',
12071207
AllowAutomaticTasks = 'task.allowAutomaticTasks',
1208-
Reconnection = 'task.experimental.reconnection'
1208+
Reconnection = 'task.reconnection'
12091209
}
12101210

12111211
export const enum TasksSchemaProperties {

0 commit comments

Comments
 (0)