Merge pull request microsoft#164667 from microsoft/issue163133

rebornix · web-flow · commit 851a0dad5ddb · 2022-10-26T11:58:45.000-07:00
Do not interrupt if there are no affected cells
diff --git a/src/vs/workbench/contrib/notebook/browser/services/notebookExecutionStateServiceImpl.ts b/src/vs/workbench/contrib/notebook/browser/services/notebookExecutionStateServiceImpl.ts
@@ -307,7 +307,9 @@ class NotebookExecutionListeners extends Disposable {
 				const implementsInterrupt = kernel.implementsInterrupt;
 				const handlesToCancel = implementsInterrupt ? [...executingDeletedHandles] : [...executingDeletedHandles, ...pendingDeletedHandles];
 				this._logService.debug(`NotebookExecution#onWillAddRemoveCells, ${JSON.stringify([...handlesToCancel])}`);
-				kernel.cancelNotebookCellExecution(this._notebookModel.uri, handlesToCancel);
+				if (handlesToCancel.length) {
+					kernel.cancelNotebookCellExecution(this._notebookModel.uri, handlesToCancel);
+				}
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,9 @@ class NotebookExecutionListeners extends Disposable {`
`307`	`307`	`const implementsInterrupt = kernel.implementsInterrupt;`
`308`	`308`	`const handlesToCancel = implementsInterrupt ? [...executingDeletedHandles] : [...executingDeletedHandles, ...pendingDeletedHandles];`
`309`	`309`	this._logService.debug(`NotebookExecution#onWillAddRemoveCells, ${JSON.stringify([...handlesToCancel])}`);
`310`		`- kernel.cancelNotebookCellExecution(this._notebookModel.uri, handlesToCancel);`
	`310`	`+ if (handlesToCancel.length) {`
	`311`	`+ kernel.cancelNotebookCellExecution(this._notebookModel.uri, handlesToCancel);`
	`312`	`+ }`
`311`	`313`	`}`
`312`	`314`	`}`
`313`	`315`	`}`