does not appear to work with when clauses inside of menu

aiday-mar · aiday-mar · commit 869503b6e49b · 2023-07-13T14:13:37.000+02:00
diff --git a/src/vs/workbench/contrib/inlineChat/browser/inlineChatActions.ts b/src/vs/workbench/contrib/inlineChat/browser/inlineChatActions.ts
@@ -462,8 +462,8 @@ export class ToggleInlineDiff extends AbstractInlineChatAction {
 				mnemonicTitle: localize({ key: 'miShowDiff2', comment: ['&& denotes a mnemonic'] }, "&&Show Diff")
 			},
 			menu: [
-				{ id: MenuId.CommandPalette },
-				{ id: MENU_INLINE_CHAT_WIDGET_TOGGLE }
+				{ id: MenuId.CommandPalette, when: CTX_INLINE_CHAT_EDIT_MODE.notEqualsTo(EditMode.Preview) },
+				{ id: MENU_INLINE_CHAT_WIDGET_TOGGLE, when: CTX_INLINE_CHAT_EDIT_MODE.notEqualsTo(EditMode.Preview) }
 			]
 		});
 	}

Original file line number	Diff line number	Diff line change
`@@ -462,8 +462,8 @@ export class ToggleInlineDiff extends AbstractInlineChatAction {`
`462`	`462`	`mnemonicTitle: localize({ key: 'miShowDiff2', comment: ['&& denotes a mnemonic'] }, "&&Show Diff")`
`463`	`463`	`},`
`464`	`464`	`menu: [`
`465`		`- { id: MenuId.CommandPalette },`
`466`		`- { id: MENU_INLINE_CHAT_WIDGET_TOGGLE }`
	`465`	`+ { id: MenuId.CommandPalette, when: CTX_INLINE_CHAT_EDIT_MODE.notEqualsTo(EditMode.Preview) },`
	`466`	`+ { id: MENU_INLINE_CHAT_WIDGET_TOGGLE, when: CTX_INLINE_CHAT_EDIT_MODE.notEqualsTo(EditMode.Preview) }`
`467`	`467`	`]`
`468`	`468`	`});`
`469`	`469`	`}`