clear diagnostics on delete, no diagnostics for IW cells (microsoft#208794)

Author: amunger

src/vs/workbench/contrib/notebook/browser/contrib/cellDiagnostics/cellDiagnostics.ts

@@ -38,14 +38,16 @@ export class CellDiagnostics extends Disposable {
 	) {
 		super();
 
-		this.updateEnabled();
+		if (cell.viewType !== 'interactive') {
+			this.updateEnabled();
 
-		this._register(inlineChatService.onDidChangeProviders(() => this.updateEnabled()));
-		this._register(configurationService.onDidChangeConfiguration((e) => {
-			if (e.affectsConfiguration(NotebookSetting.cellFailureDiagnostics)) {
-				this.updateEnabled();
-			}
-		}));
+			this._register(inlineChatService.onDidChangeProviders(() => this.updateEnabled()));
+			this._register(configurationService.onDidChangeConfiguration((e) => {
+				if (e.affectsConfiguration(NotebookSetting.cellFailureDiagnostics)) {
+					this.updateEnabled();
+				}
+			}));
+		}
 	}
 
 	private updateEnabled() {
@@ -103,4 +105,9 @@ export class CellDiagnostics extends Disposable {
 		};
 	}
 
+	override dispose() {
+		super.dispose();
+		this.clear();
+	}
+
 }