bunch of memory leaks. dispose of everything.

Yoyokrazy · Yoyokrazy · commit 8888ed6f977c · 2023-07-26T16:47:14.000-07:00
diff --git a/src/vs/workbench/contrib/notebook/browser/contrib/outline/notebookOutline.ts b/src/vs/workbench/contrib/notebook/browser/contrib/outline/notebookOutline.ts
@@ -314,6 +314,7 @@ export class NotebookCellOutline implements IOutline<OutlineEntry> {
 		this._onDidChange.dispose();
 		this._dispoables.dispose();
 		this._entriesDisposables.dispose();
+		this._outlineProvider?.dispose();
 	}
 }
 
diff --git a/src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts b/src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts
@@ -324,7 +324,7 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
 
 		this._register(this.instantiationService.createInstance(NotebookEditorContextKeys, this));
 
-		this._notebookOutline = this.instantiationService.createInstance(NotebookCellOutlineProvider, this, OutlineTarget.QuickPick);
+		this._notebookOutline = this._register(this.instantiationService.createInstance(NotebookCellOutlineProvider, this, OutlineTarget.QuickPick));
 
 		this._register(notebookKernelService.onDidChangeSelectedNotebooks(e => {
 			if (isEqual(e.notebook, this.viewModel?.uri)) {

Original file line number	Diff line number	Diff line change
`@@ -314,6 +314,7 @@ export class NotebookCellOutline implements IOutline<OutlineEntry> {`
`314`	`314`	`this._onDidChange.dispose();`
`315`	`315`	`this._dispoables.dispose();`
`316`	`316`	`this._entriesDisposables.dispose();`
	`317`	`+ this._outlineProvider?.dispose();`
`317`	`318`	`}`
`318`	`319`	`}`
`319`	`320`