Skip to content

Commit 88e4667

Browse files
authored
use helper function a la ben (microsoft#172435)
1 parent aaeb401 commit 88e4667

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

src/vs/workbench/contrib/workspace/browser/workspaceTrustEditor.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { Codicon } from 'vs/base/common/codicons';
1515
import { debounce } from 'vs/base/common/decorators';
1616
import { Emitter, Event } from 'vs/base/common/event';
1717
import { KeyCode, KeyMod } from 'vs/base/common/keyCodes';
18-
import { splitName } from 'vs/base/common/labels';
18+
import { normalizeDriveLetter, splitName } from 'vs/base/common/labels';
1919
import { Disposable, DisposableStore } from 'vs/base/common/lifecycle';
2020
import { parseLinkedText } from 'vs/base/common/linkedText';
2121
import { Schemas } from 'vs/base/common/network';
@@ -55,7 +55,7 @@ import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent';
5555
import { IProductService } from 'vs/platform/product/common/productService';
5656
import { registerIcon } from 'vs/platform/theme/common/iconRegistry';
5757
import { defaultButtonStyles, defaultInputBoxStyles } from 'vs/platform/theme/browser/defaultStyles';
58-
import { isMacintosh, isWindows } from 'vs/base/common/platform';
58+
import { isMacintosh } from 'vs/base/common/platform';
5959
import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';
6060
import { ResolvedKeybinding } from 'vs/base/common/keybindings';
6161

@@ -576,11 +576,7 @@ class TrustedUriPathColumnRenderer implements ITableRenderer<ITrustedUriItem, IT
576576

577577
private formatPath(uri: URI): string {
578578
if (uri.scheme === Schemas.file) {
579-
if (hasDriveLetter(uri.fsPath, isWindows)) {
580-
return uri.fsPath.charAt(0).toUpperCase() + uri.fsPath.substring(1);
581-
}
582-
583-
return uri.fsPath;
579+
return normalizeDriveLetter(uri.fsPath);
584580
}
585581

586582
// If the path is not a file uri, but points to a windows remote, we should create windows fs path
@@ -589,7 +585,7 @@ class TrustedUriPathColumnRenderer implements ITableRenderer<ITrustedUriItem, IT
589585
const pathWithoutLeadingSeparator = uri.path.substring(1);
590586
const isWindowsPath = hasDriveLetter(pathWithoutLeadingSeparator, true);
591587
if (isWindowsPath) {
592-
return win32.normalize(pathWithoutLeadingSeparator);
588+
return normalizeDriveLetter(win32.normalize(pathWithoutLeadingSeparator), true);
593589
}
594590
}
595591

0 commit comments

Comments
 (0)