Skip to content

Commit 8bc6f0c

Browse files
committed
trueIfUntrusted -> inUntrustedWorkspace
1 parent 4da629d commit 8bc6f0c

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

src/vs/editor/common/config/editorOptions.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3249,21 +3249,21 @@ class EditorScrollbar extends BaseEditorOption<EditorOption.scrollbar, InternalE
32493249

32503250
//#region UnicodeHighlight
32513251

3252-
export type TrueIfUntrusted = 'trueIfUntrusted';
3252+
export type InUntrustedWorkspace = 'inUntrustedWorkspace';
32533253

32543254
/**
32553255
* @internal
32563256
*/
3257-
export const trueIfUntrusted: TrueIfUntrusted = 'trueIfUntrusted';
3257+
export const inUntrustedWorkspace: InUntrustedWorkspace = 'inUntrustedWorkspace';
32583258

32593259
/**
32603260
* Configuration options for unicode highlighting.
32613261
*/
32623262
export interface IUnicodeHighlightOptions {
3263-
nonBasicASCII?: boolean | TrueIfUntrusted;
3263+
nonBasicASCII?: boolean | InUntrustedWorkspace;
32643264
invisibleCharacters?: boolean;
32653265
ambiguousCharacters?: boolean;
3266-
includeComments?: boolean | TrueIfUntrusted;
3266+
includeComments?: boolean | InUntrustedWorkspace;
32673267
/**
32683268
* A list of allowed code points in a single string.
32693269
*/
@@ -3289,10 +3289,10 @@ export const unicodeHighlightConfigKeys = {
32893289
class UnicodeHighlight extends BaseEditorOption<EditorOption.unicodeHighlighting, InternalUnicodeHighlightOptions> {
32903290
constructor() {
32913291
const defaults: InternalUnicodeHighlightOptions = {
3292-
nonBasicASCII: trueIfUntrusted,
3292+
nonBasicASCII: inUntrustedWorkspace,
32933293
invisibleCharacters: true,
32943294
ambiguousCharacters: true,
3295-
includeComments: trueIfUntrusted,
3295+
includeComments: inUntrustedWorkspace,
32963296
allowedCharacters: '',
32973297
};
32983298

@@ -3302,7 +3302,7 @@ class UnicodeHighlight extends BaseEditorOption<EditorOption.unicodeHighlighting
33023302
[unicodeHighlightConfigKeys.nonBasicASCII]: {
33033303
restricted: true,
33043304
type: ['boolean', 'string'],
3305-
enum: [true, false, trueIfUntrusted],
3305+
enum: [true, false, inUntrustedWorkspace],
33063306
default: defaults.nonBasicASCII,
33073307
description: nls.localize('unicodeHighlight.nonBasicASCII', "Controls whether all non-basic ASCII characters are highlighted. Only characters between U+0020 and U+007E, tab, line-feed and carriage-return are considered basic ASCII.")
33083308
},
@@ -3321,7 +3321,7 @@ class UnicodeHighlight extends BaseEditorOption<EditorOption.unicodeHighlighting
33213321
[unicodeHighlightConfigKeys.includeComments]: {
33223322
restricted: true,
33233323
type: ['boolean', 'string'],
3324-
enum: [true, false, trueIfUntrusted],
3324+
enum: [true, false, inUntrustedWorkspace],
33253325
default: defaults.includeComments,
33263326
description: nls.localize('unicodeHighlight.includeComments', "Controls whether characters in comments should also be subject to unicode highlighting.")
33273327
},
@@ -3341,10 +3341,10 @@ class UnicodeHighlight extends BaseEditorOption<EditorOption.unicodeHighlighting
33413341
}
33423342
const input = _input as IUnicodeHighlightOptions;
33433343
return {
3344-
nonBasicASCII: primitiveSet<boolean | TrueIfUntrusted>(input.nonBasicASCII, trueIfUntrusted, [true, false, trueIfUntrusted]),
3344+
nonBasicASCII: primitiveSet<boolean | InUntrustedWorkspace>(input.nonBasicASCII, inUntrustedWorkspace, [true, false, inUntrustedWorkspace]),
33453345
invisibleCharacters: boolean(input.invisibleCharacters, this.defaultValue.invisibleCharacters),
33463346
ambiguousCharacters: boolean(input.ambiguousCharacters, this.defaultValue.ambiguousCharacters),
3347-
includeComments: primitiveSet<boolean | TrueIfUntrusted>(input.includeComments, trueIfUntrusted, [true, false, trueIfUntrusted]),
3347+
includeComments: primitiveSet<boolean | InUntrustedWorkspace>(input.includeComments, inUntrustedWorkspace, [true, false, inUntrustedWorkspace]),
33483348
allowedCharacters: string(input.allowedCharacters, ''),
33493349
};
33503350
}

src/vs/editor/contrib/unicodeHighlighter/unicodeHighlighter.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { InvisibleCharacters } from 'vs/base/common/strings';
1212
import 'vs/css!./unicodeHighlighter';
1313
import { IActiveCodeEditor, ICodeEditor } from 'vs/editor/browser/editorBrowser';
1414
import { EditorAction, registerEditorAction, registerEditorContribution, ServicesAccessor } from 'vs/editor/browser/editorExtensions';
15-
import { TrueIfUntrusted, trueIfUntrusted, EditorOption, InternalUnicodeHighlightOptions, unicodeHighlightConfigKeys } from 'vs/editor/common/config/editorOptions';
15+
import { InUntrustedWorkspace, inUntrustedWorkspace, EditorOption, InternalUnicodeHighlightOptions, unicodeHighlightConfigKeys } from 'vs/editor/common/config/editorOptions';
1616
import { Range } from 'vs/editor/common/core/range';
1717
import { IEditorContribution } from 'vs/editor/common/editorCommon';
1818
import { IModelDecoration, IModelDeltaDecoration, ITextModel, MinimapPosition, OverviewRulerLane, TrackedRangeStickiness } from 'vs/editor/common/model';
@@ -181,15 +181,15 @@ export interface UnicodeHighlighterDecorationInfo {
181181
reason: UnicodeHighlighterReason;
182182
}
183183

184-
type RemoveTrueIfUntrusted<T> = T extends TrueIfUntrusted ? never : T;
184+
type RemoveTrueIfUntrusted<T> = T extends InUntrustedWorkspace ? never : T;
185185
type ResolvedOptions = { [TKey in keyof InternalUnicodeHighlightOptions]: RemoveTrueIfUntrusted<InternalUnicodeHighlightOptions[TKey]> };
186186

187187
function resolveOptions(trusted: boolean, options: InternalUnicodeHighlightOptions): ResolvedOptions {
188188
return {
189-
nonBasicASCII: options.nonBasicASCII === trueIfUntrusted ? !trusted : options.nonBasicASCII,
189+
nonBasicASCII: options.nonBasicASCII === inUntrustedWorkspace ? !trusted : options.nonBasicASCII,
190190
ambiguousCharacters: options.ambiguousCharacters,
191191
invisibleCharacters: options.invisibleCharacters,
192-
includeComments: options.includeComments === trueIfUntrusted ? !trusted : options.includeComments,
192+
includeComments: options.includeComments === inUntrustedWorkspace ? !trusted : options.includeComments,
193193
allowedCharacters: options.allowedCharacters ?? [],
194194
};
195195
}

src/vs/monaco.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3863,16 +3863,16 @@ declare namespace monaco.editor {
38633863
readonly scrollByPage: boolean;
38643864
}
38653865

3866-
export type TrueIfUntrusted = 'trueIfUntrusted';
3866+
export type InUntrustedWorkspace = 'inUntrustedWorkspace';
38673867

38683868
/**
38693869
* Configuration options for unicode highlighting.
38703870
*/
38713871
export interface IUnicodeHighlightOptions {
3872-
nonBasicASCII?: boolean | TrueIfUntrusted;
3872+
nonBasicASCII?: boolean | InUntrustedWorkspace;
38733873
invisibleCharacters?: boolean;
38743874
ambiguousCharacters?: boolean;
3875-
includeComments?: boolean | TrueIfUntrusted;
3875+
includeComments?: boolean | InUntrustedWorkspace;
38763876
/**
38773877
* A list of allowed code points in a single string.
38783878
*/

0 commit comments

Comments
 (0)