use export function x(...) instead of export const x (microsoft#250927)

Author: aeschli

src/vs/workbench/contrib/chat/browser/promptSyntax/attachInstructionsAction.ts

@@ -197,22 +197,22 @@ function getFocusedChatWidget(accessor: ServicesAccessor): IChatWidget | undefin
 /**
  * Gets `URI` of a instructions file open in an active editor instance, if any.
  */
-const getActiveInstructionsFileUri = (accessor: ServicesAccessor): URI | undefined => {
+function getActiveInstructionsFileUri(accessor: ServicesAccessor): URI | undefined {
 	const codeEditorService = accessor.get(ICodeEditorService);
 	const model = codeEditorService.getActiveCodeEditor()?.getModel();
 	if (model?.getLanguageId() === INSTRUCTIONS_LANGUAGE_ID) {
 		return model.uri;
 	}
 	return undefined;
-};
+}
 
 /**
  * Helper to register the `Attach Prompt` action.
  */
-export const registerAttachPromptActions = () => {
+export function registerAttachPromptActions(): void {
 	registerAction2(AttachInstructionsAction);
 	registerAction2(ManageInstructionsFilesAction);
-};
+}
 
 
 export class ChatInstructionsPickerPick implements IChatContextPickerItem {

src/vs/workbench/contrib/chat/browser/promptSyntax/chatModeActions.ts

@@ -46,9 +46,7 @@ class ManageModeAction extends Action2 {
 		});
 	}
 
-	public override async run(
-		accessor: ServicesAccessor,
-	): Promise<void> {
+	public override async run(accessor: ServicesAccessor): Promise<void> {
 		const openerService = accessor.get(IOpenerService);
 		const instaService = accessor.get(IInstantiationService);
 
@@ -69,6 +67,6 @@ class ManageModeAction extends Action2 {
 /**
  * Helper to register all the `Run Current Prompt` actions.
  */
-export const registerChatModeActions = () => {
+export function registerChatModeActions(): void {
 	registerAction2(ManageModeAction);
-};
+}

src/vs/workbench/contrib/chat/browser/promptSyntax/saveToPromptAction.ts

@@ -139,9 +139,7 @@ class SaveToPromptAction extends Action2 {
  * Check if provided message belongs to the `save to prompt` slash
  * command itself that was run in the chat to invoke this action.
  */
-const isSaveToPromptSlashCommand = (
-	message: IParsedChatRequest,
-): boolean => {
+function isSaveToPromptSlashCommand(message: IParsedChatRequest): boolean {
 	const { parts } = message;
 	if (parts.length < 1) {
 		return false;
@@ -157,14 +155,12 @@ const isSaveToPromptSlashCommand = (
 	}
 
 	return true;
-};
+}
 
 /**
  * Render the response part of a `request`/`response` turn pair.
  */
-const renderResponse = (
-	response: string,
-): string => {
+function renderResponse(response: string): string {
 	// if response starts with a code block, add an extra new line
 	// before it, to prevent full blockquote from being be broken
 	const delimiter = (response.startsWith('```'))
@@ -176,25 +172,21 @@ const renderResponse = (
 	const quotedResponse = response.replaceAll('\n', '\n> ');
 
 	return `> Copilot:${delimiter}${quotedResponse}`;
-};
+}
 
 /**
  * Render a single `request`/`response` turn of the chat session.
  */
-const renderTurn = (
-	turn: ITurn,
-): string => {
+function renderTurn(turn: ITurn): string {
 	const { request, response } = turn;
 
 	return `\n${request}\n\n${renderResponse(response)}`;
-};
+}
 
 /**
  * Render the entire chat session as a markdown prompt.
  */
-const renderPrompt = (
-	turns: readonly ITurn[],
-): string => {
+function renderPrompt(turns: readonly ITurn[]): string {
 	const content: string[] = [];
 	const allTools = new Set<string>();
 
@@ -225,28 +217,24 @@ const renderPrompt = (
 	result.push('');
 
 	return result.join('\n');
-};
+}
 
 
 /**
  * Render the `tools` metadata inside prompt header.
  */
-const renderTools = (
-	tools: Set<string>,
-): string => {
+function renderTools(tools: Set<string>): string {
 	const toolStrings = [...tools].map((tool) => {
 		return `'${tool}'`;
 	});
 
 	return `tools: [${toolStrings.join(', ')}]`;
-};
+}
 
 /**
  * Render prompt header.
  */
-const renderHeader = (
-	tools: Set<string>,
-): string => {
+function renderHeader(tools: Set<string>): string {
 	// skip rendering the header if no tools provided
 	if (tools.size === 0) {
 		return '';
@@ -257,7 +245,7 @@ const renderHeader = (
 		renderTools(tools),
 		'---',
 	].join('\n');
-};
+}
 
 /**
  * Interface for a single `request`/`response` turn
@@ -274,19 +262,19 @@ interface ITurn {
  * function instead of {@link SAVE_TO_PROMPT_ACTION_ID} directly to
  * encapsulate/enforce the correct options to be passed to the action.
  */
-export const runSaveToPromptAction = async (
+export function runSaveToPromptAction(
 	options: ISaveToPromptActionOptions,
 	commandService: ICommandService,
-) => {
-	return await commandService.executeCommand(
+) {
+	return commandService.executeCommand(
 		SAVE_TO_PROMPT_ACTION_ID,
 		options,
 	);
-};
+}
 
 /**
  * Helper to register all the `Save Prompt` actions.
  */
-export const registerSaveToPromptActions = () => {
+export function registerSaveToPromptActions(): void {
 	registerAction2(SaveToPromptAction);
-};
+}

src/vs/workbench/contrib/chat/common/promptSyntax/codecs/base/frontMatterCodec/parsers/frontMatterRecord/frontMatterRecord.ts

@@ -199,12 +199,10 @@ export class PartialFrontMatterRecord extends ParserBase<TSimpleDecoderToken, TN
  * Callback to check if a current token should end a
  * record value that is a generic sequence of tokens.
  */
-const shouldEndTokenSequence = (
-	token: BaseToken,
-): token is (NewLine | CarriageReturn | FormFeed) => {
+function shouldEndTokenSequence(token: BaseToken): token is (NewLine | CarriageReturn | FormFeed) {
 	return (
 		(token instanceof NewLine)
 		|| (token instanceof CarriageReturn)
 		|| (token instanceof FormFeed)
 	);
-};
+}

src/vs/workbench/contrib/chat/common/promptSyntax/codecs/base/utils/objectStream.ts

@@ -215,10 +215,10 @@ export class ObjectStream<T extends object> extends ObservableDisposable impleme
 /**
  * Create a generator out of a provided array.
  */
-export const arrayToGenerator = <T extends NonNullable<unknown>>(array: T[]): Generator<T, undefined> => {
+export function arrayToGenerator<T extends NonNullable<unknown>>(array: T[]): Generator<T, undefined> {
 	return (function* (): Generator<T, undefined> {
 		for (const item of array) {
 			yield item;
 		}
 	})();
-};
+}

src/vs/workbench/contrib/chat/common/promptSyntax/codecs/base/utils/objectStreamFromTextModel.ts

@@ -21,9 +21,7 @@ export function objectStreamFromTextModel(
 /**
  * Create a generator out of a provided text model.
  */
-const modelToGenerator = (
-	model: ITextModel,
-): Generator<VSBuffer, undefined> => {
+function modelToGenerator(model: ITextModel): Generator<VSBuffer, undefined> {
 	return (function* (): Generator<VSBuffer, undefined> {
 		const totalLines = model.getLineCount();
 		let currentLine = 1;
@@ -45,4 +43,4 @@ const modelToGenerator = (
 			currentLine++;
 		}
 	})();
-};
+}

src/vs/workbench/contrib/chat/common/promptSyntax/languageProviders/promptHeaderDiagnosticsProvider.ts

@@ -80,9 +80,7 @@ class PromptHeaderDiagnosticsProvider extends ProviderInstanceBase {
 /**
  * Convert a provided diagnostic object into a marker data object.
  */
-const toMarker = (
-	diagnostic: TDiagnostic,
-): IMarkerData => {
+function toMarker(diagnostic: TDiagnostic): IMarkerData {
 	if (diagnostic instanceof PromptMetadataWarning) {
 		return {
 			message: diagnostic.message,
@@ -103,7 +101,7 @@ const toMarker = (
 		diagnostic,
 		`Unknown prompt metadata diagnostic type '${diagnostic}'.`,
 	);
-};
+}
 
 /**
  * The class that manages creation and disposal of {@link PromptHeaderDiagnosticsProvider}

src/vs/workbench/contrib/chat/common/promptSyntax/languageProviders/promptLinkDiagnosticsProvider.ts

@@ -83,9 +83,7 @@ class PromptLinkDiagnosticsProvider extends ProviderInstanceBase {
  *  - if the original error is of `NotPromptFile` type - we don't want to
  *    show diagnostic markers for non-prompt file links in the prompts
  */
-const toMarker = (
-	link: IPromptFileReference,
-): IMarkerData => {
+function toMarker(link: IPromptFileReference): IMarkerData {
 	const { topError, linkRange } = link;
 
 	// a sanity check because this function must be
@@ -115,7 +113,7 @@ const toMarker = (
 		severity,
 		...linkRange,
 	};
-};
+}
 
 /**
  * The class that manages creation and disposal of {@link PromptLinkDiagnosticsProvider}

src/vs/workbench/contrib/chat/common/promptSyntax/languageProviders/promptPathAutocompletion.ts

@@ -51,10 +51,7 @@ type TTriggerCharacter = ':' | '.' | '/';
 /**
  * Finds a file reference that suites the provided `position`.
  */
-const findFileReference = (
-	references: readonly TPromptReference[],
-	position: Position,
-): IPromptFileReference | undefined => {
+function findFileReference(references: readonly TPromptReference[], position: Position): IPromptFileReference | undefined {
 	for (const reference of references) {
 		const { range } = reference;
 
@@ -78,7 +75,7 @@ const findFileReference = (
 	}
 
 	return undefined;
-};
+}
 
 /**
  * Provides reference paths autocompletion for the `#file:` variables inside prompts.

src/vs/workbench/contrib/chat/common/promptSyntax/languageProviders/providerInstanceManagerBase.ts

@@ -147,22 +147,18 @@ export abstract class ProviderInstanceManagerBase<TInstance extends ProviderInst
 /**
  * Check if provided language ID is one of the prompt file languages.
  */
-const isPromptFile = (
-	languageId: string,
-): boolean => {
+function isPromptFile(languageId: string): boolean {
 	return [
 		PROMPT_LANGUAGE_ID,
 		INSTRUCTIONS_LANGUAGE_ID,
 		MODE_LANGUAGE_ID,
 	].includes(languageId);
-};
+}
 
 /**
  * Check if a provided model is used for prompt files.
  */
-const isPromptFileModel = (
-	model: IEditorModel,
-): model is ITextModel => {
+function isPromptFileModel(model: IEditorModel): model is ITextModel {
 	// we support only `text editors` for now so filter out `diff` ones
 	if ('modified' in model || 'model' in model) {
 		return false;
@@ -177,4 +173,4 @@ const isPromptFileModel = (
 	}
 
 	return true;
-};
+}