fix microsoft#199299 (microsoft#199497)

sandy081 · web-flow · commit 8df51ff830b3 · 2023-11-29T09:33:07.000+01:00
diff --git a/src/vs/workbench/contrib/markers/browser/markers.contribution.ts b/src/vs/workbench/contrib/markers/browser/markers.contribution.ts
@@ -677,8 +677,12 @@ class ActivityUpdater extends Disposable implements IWorkbenchContribution {
 	private updateBadge(): void {
 		const { errors, warnings, infos } = this.markerService.getStatistics();
 		const total = errors + warnings + infos;
-		const message = localize('totalProblems', 'Total {0} Problems', total);
-		this.activity.value = this.activityService.showViewActivity(Markers.MARKERS_VIEW_ID, { badge: new NumberBadge(total, () => message) });
+		if (total > 0) {
+			const message = localize('totalProblems', 'Total {0} Problems', total);
+			this.activity.value = this.activityService.showViewActivity(Markers.MARKERS_VIEW_ID, { badge: new NumberBadge(total, () => message) });
+		} else {
+			this.activity.value = undefined;
+		}
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -677,8 +677,12 @@ class ActivityUpdater extends Disposable implements IWorkbenchContribution {`
`677`	`677`	`private updateBadge(): void {`
`678`	`678`	`const { errors, warnings, infos } = this.markerService.getStatistics();`
`679`	`679`	`const total = errors + warnings + infos;`
`680`		`- const message = localize('totalProblems', 'Total {0} Problems', total);`
`681`		`- this.activity.value = this.activityService.showViewActivity(Markers.MARKERS_VIEW_ID, { badge: new NumberBadge(total, () => message) });`
	`680`	`+ if (total > 0) {`
	`681`	`+ const message = localize('totalProblems', 'Total {0} Problems', total);`
	`682`	`+ this.activity.value = this.activityService.showViewActivity(Markers.MARKERS_VIEW_ID, { badge: new NumberBadge(total, () => message) });`
	`683`	`+ } else {`
	`684`	`+ this.activity.value = undefined;`
	`685`	`+ }`
`682`	`686`	`}`
`683`	`687`	`}`
`684`	`688`