Skip to content

Commit 9243c3d

Browse files
authored
Ensure no disposables leak (microsoft#209040)
1 parent f62931d commit 9243c3d

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

.eslintrc.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@
159159
"src/vs/platform/opener/test/common/opener.test.ts",
160160
"src/vs/platform/registry/test/common/platform.test.ts",
161161
"src/vs/platform/remote/test/common/remoteHosts.test.ts",
162-
"src/vs/platform/telemetry/test/browser/1dsAppender.test.ts",
163162
"src/vs/platform/workspace/test/common/workspace.test.ts",
164163
"src/vs/platform/workspaces/test/electron-main/workspaces.test.ts",
165164
"src/vs/workbench/api/test/browser/mainThreadConfiguration.test.ts",

src/vs/platform/telemetry/test/browser/1dsAppender.test.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
*--------------------------------------------------------------------------------------------*/
55
import type { ITelemetryItem, ITelemetryUnloadState } from '@microsoft/1ds-core-js';
66
import * as assert from 'assert';
7+
import { ensureNoDisposablesAreLeakedInTestSuite } from 'vs/base/test/common/utils';
78
import { OneDataSystemWebAppender } from 'vs/platform/telemetry/browser/1dsAppender';
89
import { IAppInsightsCore } from 'vs/platform/telemetry/common/1dsAppender';
910

@@ -28,14 +29,17 @@ suite('AIAdapter', () => {
2829
const prefix = 'prefix';
2930

3031

32+
teardown(() => {
33+
adapter.flush();
34+
});
35+
36+
ensureNoDisposablesAreLeakedInTestSuite();
37+
3138
setup(() => {
3239
appInsightsMock = new AppInsightsCoreMock();
3340
adapter = new OneDataSystemWebAppender(false, prefix, undefined!, () => appInsightsMock);
3441
});
3542

36-
teardown(() => {
37-
adapter.flush();
38-
});
3943

4044
test('Simple event', () => {
4145
adapter.log('testEvent');

0 commit comments

Comments
 (0)