introduce and use asStatusBarItemIdentifier

Author: jrieken

src/vs/workbench/api/common/extHostStatusBar.ts

@@ -9,9 +9,10 @@ import { MainContext, MainThreadStatusBarShape, IMainContext, ICommandDto } from
 import { localize } from 'vs/nls';
 import { CommandsConverter } from 'vs/workbench/api/common/extHostCommands';
 import { DisposableStore } from 'vs/base/common/lifecycle';
-import { ExtensionIdentifier, IExtensionDescription } from 'vs/platform/extensions/common/extensions';
+import { IExtensionDescription } from 'vs/platform/extensions/common/extensions';
 import { MarkdownString } from 'vs/workbench/api/common/extHostTypeConverters';
 import { isNumber } from 'vs/base/common/types';
+import { asStatusBarItemIdentifier } from 'vs/workbench/api/common/statusBarExtensionPoint';
 
 export class ExtHostStatusBarEntry implements vscode.StatusBarItem {
 
@@ -60,7 +61,7 @@ export class ExtHostStatusBarEntry implements vscode.StatusBarItem {
 		this.#commands = commands;
 
 		if (id && extension) {
-			this._entryId = `${ExtensionIdentifier.toKey(extension.identifier)}.${id}`;
+			this._entryId = asStatusBarItemIdentifier(extension.identifier, id);
 			proxy.$hasEntry(this._entryId).then(exits => {
 				if (exits && this._visible === undefined) {
 					// mark new item as visible if it already exists

src/vs/workbench/api/common/statusBarExtensionPoint.ts

@@ -205,13 +205,12 @@ export class StatusBarItemsExtensionPoint {
 						continue;
 					}
 
-					const extensionId = ExtensionIdentifier.toKey(entry.description.identifier);
-					const fullItemId = `${extensionId}.${candidate.id}`;
+					const fullItemId = asStatusBarItemIdentifier(entry.description.identifier, candidate.id);
 
 					contributions.add(statusBarItemsService.setOrUpdateEntry(
 						fullItemId,
 						fullItemId,
-						extensionId,
+						ExtensionIdentifier.toKey(entry.description.identifier),
 						candidate.name ?? entry.description.displayName ?? entry.description.name,
 						candidate.text,
 						undefined, undefined, undefined, undefined,
@@ -224,3 +223,8 @@ export class StatusBarItemsExtensionPoint {
 		});
 	}
 }
+
+
+export function asStatusBarItemIdentifier(extension: ExtensionIdentifier, id: string): string {
+	return `${ExtensionIdentifier.toKey(extension)}.${id}`;
+}