add supportsMarkerHover to HoverForeignElementAnchor and use for inlay hovering (microsoft#172532)

* add `supportsMarkerHover` to `HoverForeignElementAnchor` and use for inlay hovering

fixed microsoft#140517

* make compiler happy

Author: jrieken

src/vs/editor/contrib/hover/browser/contentHover.ts

@@ -639,7 +639,7 @@ class ContentHoverComputer implements IHoverComputer<IHoverPart> {
 	}
 
 	private static _getLineDecorations(editor: IActiveCodeEditor, anchor: HoverAnchor): IModelDecoration[] {
-		if (anchor.type !== HoverAnchorType.Range) {
+		if (anchor.type !== HoverAnchorType.Range && !anchor.supportsMarkerHover) {
 			return [];
 		}
 

src/vs/editor/contrib/hover/browser/hoverTypes.ts

@@ -67,6 +67,7 @@ export class HoverForeignElementAnchor {
 		public readonly range: Range,
 		public readonly initialMousePosX: number | undefined,
 		public readonly initialMousePosY: number | undefined,
+		public readonly supportsMarkerHover: boolean | undefined
 	) {
 	}
 	public equals(other: HoverAnchor) {

src/vs/editor/contrib/hover/browser/markerHoverParticipant.ts

@@ -66,7 +66,7 @@ export class MarkerHoverParticipant implements IEditorHoverParticipant<MarkerHov
 	) { }
 
 	public computeSync(anchor: HoverAnchor, lineDecorations: IModelDecoration[]): MarkerHover[] {
-		if (!this._editor.hasModel() || anchor.type !== HoverAnchorType.Range) {
+		if (!this._editor.hasModel() || anchor.type !== HoverAnchorType.Range && !anchor.supportsMarkerHover) {
 			return [];
 		}
 

src/vs/editor/contrib/inlayHints/browser/inlayHintsHover.ts

@@ -32,7 +32,7 @@ class InlayHintsHoverAnchor extends HoverForeignElementAnchor {
 		initialMousePosX: number | undefined,
 		initialMousePosY: number | undefined
 	) {
-		super(10, owner, part.item.anchor.range, initialMousePosX, initialMousePosY);
+		super(10, owner, part.item.anchor.range, initialMousePosX, initialMousePosY, true);
 	}
 }
 

src/vs/editor/contrib/inlineCompletions/browser/ghostTextHoverParticipant.ts

@@ -86,20 +86,20 @@ export class InlineCompletionsHoverParticipant implements IEditorHoverParticipan
 			// handle the case where the mouse is over the view zone
 			const viewZoneData = target.detail;
 			if (controller.shouldShowHoverAtViewZone(viewZoneData.viewZoneId)) {
-				return new HoverForeignElementAnchor(1000, this, Range.fromPositions(this._editor.getModel()!.validatePosition(viewZoneData.positionBefore || viewZoneData.position)), mouseEvent.event.posx, mouseEvent.event.posy);
+				return new HoverForeignElementAnchor(1000, this, Range.fromPositions(this._editor.getModel()!.validatePosition(viewZoneData.positionBefore || viewZoneData.position)), mouseEvent.event.posx, mouseEvent.event.posy, false);
 			}
 		}
 		if (target.type === MouseTargetType.CONTENT_EMPTY) {
 			// handle the case where the mouse is over the empty portion of a line following ghost text
 			if (controller.shouldShowHoverAt(target.range)) {
-				return new HoverForeignElementAnchor(1000, this, target.range, mouseEvent.event.posx, mouseEvent.event.posy);
+				return new HoverForeignElementAnchor(1000, this, target.range, mouseEvent.event.posx, mouseEvent.event.posy, false);
 			}
 		}
 		if (target.type === MouseTargetType.CONTENT_TEXT) {
 			// handle the case where the mouse is directly over ghost text
 			const mightBeForeignElement = target.detail.mightBeForeignElement;
 			if (mightBeForeignElement && controller.shouldShowHoverAt(target.range)) {
-				return new HoverForeignElementAnchor(1000, this, target.range, mouseEvent.event.posx, mouseEvent.event.posy);
+				return new HoverForeignElementAnchor(1000, this, target.range, mouseEvent.event.posx, mouseEvent.event.posy, false);
 			}
 		}
 		return null;