add terminal to taskExecution (microsoft#254477)

fix microsoft#234440

Author: meganrogge

src/vs/platform/extensions/common/extensionsApiProposals.ts

@@ -344,6 +344,9 @@ const _allApiProposals = {
 	tabInputTextMerge: {
 		proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.tabInputTextMerge.d.ts',
 	},
+	taskExecutionTerminal: {
+		proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.taskExecutionTerminal.d.ts',
+	},
 	taskPresentationGroup: {
 		proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.taskPresentationGroup.d.ts',
 	},

src/vs/workbench/api/common/extHost.api.impl.ts

@@ -1358,6 +1358,9 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
 				return extHostTask.taskExecutions;
 			},
 			onDidStartTask: (listeners, thisArgs?, disposables?) => {
+				if (!isProposedApiEnabled(extension, 'taskExecutionTerminal')) {
+					thisArgs.terminal = undefined;
+				}
 				return _asExtensionEvent(extHostTask.onDidStartTask)(listeners, thisArgs, disposables);
 			},
 			onDidEndTask: (listeners, thisArgs?, disposables?) => {

src/vs/workbench/api/common/extHostTask.ts

@@ -360,6 +360,7 @@ namespace TaskFilterDTO {
 class TaskExecutionImpl implements vscode.TaskExecution {
 
 	readonly #tasks: ExtHostTaskBase;
+	private _terminal: vscode.Terminal | undefined;
 
 	constructor(tasks: ExtHostTaskBase, readonly _id: string, private readonly _task: vscode.Task) {
 		this.#tasks = tasks;
@@ -378,6 +379,14 @@ class TaskExecutionImpl implements vscode.TaskExecution {
 
 	public fireDidEndProcess(value: tasks.ITaskProcessEndedDTO): void {
 	}
+
+	public get terminal(): vscode.Terminal | undefined {
+		return this._terminal;
+	}
+
+	public set terminal(term: vscode.Terminal | undefined) {
+		this._terminal = term;
+	}
 }
 
 export interface HandlerData {
@@ -497,8 +506,14 @@ export abstract class ExtHostTaskBase implements ExtHostTaskShape, IExtHostTask
 		}
 		this._lastStartedTask = execution.id;
 
+		const taskExecution = await this.getTaskExecution(execution);
+		const terminal = this._terminalService.getTerminalById(terminalId)?.value;
+		if (taskExecution) {
+			taskExecution.terminal = terminal;
+		}
+
 		this._onDidExecuteTask.fire({
-			execution: await this.getTaskExecution(execution)
+			execution: taskExecution
 		});
 	}
 

src/vscode-dts/vscode.proposed.taskExecutionTerminal.d.ts

@@ -0,0 +1,15 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+// #234440
+declare module 'vscode' {
+
+	export interface TaskExecution {
+		/**
+		 * The terminal associated with this task execution, if any.
+		 */
+		readonly terminal?: Terminal;
+	}
+}