Disable Nagle's algorithm for web sockets

Author: alexdima

src/vs/platform/remote/common/remoteAgentConnection.ts

@@ -573,7 +573,7 @@ export abstract class PersistentConnection extends Disposable {
 		}));
 		this._register(protocol.onSocketTimeout(() => {
 			const logPrefix = commonLogPrefix(this._connectionType, this.reconnectionToken, true);
-			this._options.logService.trace(`${logPrefix} received socket timeout event.`);
+			this._options.logService.info(`${logPrefix} received socket timeout event.`);
 			this._beginReconnecting();
 		}));
 

src/vs/platform/remote/node/nodeSocketFactory.ts

@@ -21,7 +21,7 @@ export const nodeSocketFactory = new class implements ISocketFactory {
 			}
 			const nonce = buffer.toString('base64');
 
-			let headers = [
+			const headers = [
 				`GET ws://${/:/.test(host) ? `[${host}]` : host}:${port}/?${query}&skipWebSocketFrames=true HTTP/1.1`,
 				`Connection: Upgrade`,
 				`Upgrade: websocket`,
@@ -39,6 +39,8 @@ export const nodeSocketFactory = new class implements ISocketFactory {
 			};
 			socket.on('data', onData);
 		});
+		// Disable Nagle's algorithm.
+		socket.setNoDelay(true);
 		socket.once('error', errorListener);
 	}
 };

src/vs/server/remoteExtensionHostAgentServer.ts

@@ -497,6 +497,8 @@ export class RemoteExtensionHostAgentServer extends Disposable {
 
 		// Never timeout this socket due to inactivity!
 		socket.setTimeout(0);
+		// Disable Nagle's algorithm
+		socket.setNoDelay(true);
 		// Finally!
 
 		if (skipWebSocketFrames) {

src/vs/workbench/services/extensions/node/extensionHostProcessSetup.ts

@@ -120,6 +120,10 @@ function _createExtHostProtocol(): Promise<PersistentProtocol> {
 
 			process.on('message', (msg: IExtHostSocketMessage | IExtHostReduceGraceTimeMessage, handle: net.Socket) => {
 				if (msg && msg.type === 'VSCODE_EXTHOST_IPC_SOCKET') {
+					// Disable Nagle's algorithm. We also do this on the server process,
+					// but nodejs doesn't document if this option is transferred with the socket
+					handle.setNoDelay(true);
+
 					const initialDataChunk = VSBuffer.wrap(Buffer.from(msg.initialDataChunk, 'base64'));
 					let socket: NodeSocket | WebSocketNodeSocket;
 					if (msg.skipWebSocketFrames) {