Skip to content

Commit 9639108

Browse files
committed
Fix review comments
1 parent 1d5142a commit 9639108

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/vs/editor/contrib/parameterHints/browser/parameterHints.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ import { IInstantiationService } from 'vs/platform/instantiation/common/instanti
2020
import { KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry';
2121
import { ParameterHintsWidget } from './parameterHintsWidget';
2222

23-
export const ParameterHintsContributionID = 'editor.controller.parameterHints';
23+
export class ParameterHintsController extends Disposable implements IEditorContribution {
2424

25-
class ParameterHintsController extends Disposable implements IEditorContribution {
25+
public static readonly ID = 'editor.controller.parameterHints';
2626

2727
public static get(editor: ICodeEditor): ParameterHintsController | null {
28-
return editor.getContribution<ParameterHintsController>(ParameterHintsContributionID);
28+
return editor.getContribution<ParameterHintsController>(ParameterHintsController.ID);
2929
}
3030

3131
private readonly editor: ICodeEditor;
@@ -96,7 +96,7 @@ export class TriggerParameterHintsAction extends EditorAction {
9696
}
9797
}
9898

99-
registerEditorContribution(ParameterHintsContributionID, ParameterHintsController, EditorContributionInstantiation.BeforeFirstInteraction);
99+
registerEditorContribution(ParameterHintsController.ID, ParameterHintsController, EditorContributionInstantiation.BeforeFirstInteraction);
100100
registerEditorAction(TriggerParameterHintsAction);
101101

102102
const weight = KeybindingWeight.EditorContrib + 75;

src/vs/workbench/contrib/interactive/browser/interactiveEditor.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ import { IContextMenuService } from 'vs/platform/contextview/browser/contextView
4141
import { createActionViewItem, createAndFillInActionBarActions } from 'vs/platform/actions/browser/menuEntryActionViewItem';
4242
import { IAction } from 'vs/base/common/actions';
4343
import { EditorExtensionsRegistry } from 'vs/editor/browser/editorExtensions';
44-
import { ParameterHintsContributionID } from 'vs/editor/contrib/parameterHints/browser/parameterHints';
44+
import { ParameterHintsController } from 'vs/editor/contrib/parameterHints/browser/parameterHints';
4545
import { MenuPreventer } from 'vs/workbench/contrib/codeEditor/browser/menuPreventer';
4646
import { SelectionClipboardContributionID } from 'vs/workbench/contrib/codeEditor/browser/selectionClipboard';
4747
import { ContextMenuController } from 'vs/editor/contrib/contextmenu/browser/contextmenu';
@@ -370,10 +370,10 @@ export class InteractiveEditor extends EditorPane {
370370
SelectionClipboardContributionID,
371371
ContextMenuController.ID,
372372
SuggestController.ID,
373+
ParameterHintsController.ID,
373374
SnippetController2.ID,
374375
TabCompletionController.ID,
375376
ModesHoverController.ID,
376-
ParameterHintsContributionID,
377377
MarkerController.ID
378378
])
379379
}

0 commit comments

Comments
 (0)