Skip to content

Commit 97030b0

Browse files
committed
Clamp value to 0.2-1
1 parent 8e333c3 commit 97030b0

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

src/vs/workbench/contrib/accessibility/browser/accessibilityContribution.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,10 @@ const configuration: IConfigurationNode = {
7171
...baseProperty
7272
},
7373
[AccessibilitySettingId.UnfocusedViewOpacity]: {
74-
description: localize('unfocusedViewOpacity', 'The opacity percentage (0.0 to 1.0) to use for unfocused editors and terminals.'),
74+
description: localize('unfocusedViewOpacity', 'The opacity percentage (0.2 to 1.0) to use for unfocused editors and terminals.'),
7575
type: 'number',
76+
minimum: 0.2,
77+
maximum: 1,
7678
default: 1,
7779
tags: ['accessibility']
7880
}

src/vs/workbench/contrib/accessibility/browser/unfocusedViewDimmingContribution.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
import { Event } from 'vs/base/common/event';
77
import { Disposable, toDisposable } from 'vs/base/common/lifecycle';
8+
import { clamp } from 'vs/base/common/numbers';
89
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
910
import { IWorkbenchContribution } from 'vs/workbench/common/contributions';
1011
import { AccessibilitySettingId } from 'vs/workbench/contrib/accessibility/browser/accessibilityContribution';
@@ -25,9 +26,12 @@ export class UnfocusedViewDimmingContribution extends Disposable implements IWor
2526
return;
2627
}
2728

28-
let opacity = configurationService.getValue(AccessibilitySettingId.UnfocusedViewOpacity);
29-
if (typeof opacity !== 'number') {
29+
let opacity: number;
30+
const opacityConfig = configurationService.getValue(AccessibilitySettingId.UnfocusedViewOpacity);
31+
if (typeof opacityConfig !== 'number') {
3032
opacity = 1;
33+
} else {
34+
opacity = clamp(opacityConfig, 0.2, 1);
3135
}
3236

3337
const rules = new Set<string>();

0 commit comments

Comments
 (0)