counter revealLines-logic with sticky scroll max lines

jrieken · jrieken · commit 9953131049e1 · 2024-09-27T11:08:42.000+02:00
fixes microsoft#229934
diff --git a/src/vs/workbench/contrib/inlineChat/browser/inlineChatZoneWidget.ts b/src/vs/workbench/contrib/inlineChat/browser/inlineChatZoneWidget.ts
@@ -168,7 +168,9 @@ export class InlineChatZoneWidget extends ZoneWidget {
 	}
 
 	reveal(position: Position) {
-		this.editor.revealLinesInCenterIfOutsideViewport(position.lineNumber, position.lineNumber, ScrollType.Immediate);
+		const stickyScroll = this.editor.getOption(EditorOption.stickyScroll);
+		const magicValue = stickyScroll.enabled ? stickyScroll.maxLineCount : 0;
+		this.editor.revealLines(position.lineNumber + magicValue, position.lineNumber + magicValue, ScrollType.Immediate);
 		this._scrollUp.reset();
 		this.updatePositionAndHeight(position);
 	}

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,9 @@ export class InlineChatZoneWidget extends ZoneWidget {`
`168`	`168`	`}`
`169`	`169`
`170`	`170`	`reveal(position: Position) {`
`171`		`- this.editor.revealLinesInCenterIfOutsideViewport(position.lineNumber, position.lineNumber, ScrollType.Immediate);`
	`171`	`+ const stickyScroll = this.editor.getOption(EditorOption.stickyScroll);`
	`172`	`+ const magicValue = stickyScroll.enabled ? stickyScroll.maxLineCount : 0;`
	`173`	`+ this.editor.revealLines(position.lineNumber + magicValue, position.lineNumber + magicValue, ScrollType.Immediate);`
`172`	`174`	`this._scrollUp.reset();`
`173`	`175`	`this.updatePositionAndHeight(position);`
`174`	`176`	`}`