Skip to content

Commit 9ace93e

Browse files
Copilothediet
andauthored
Avoid 0ms interval rescheduling in configuration service (microsoft#259524)
* Fixes microsoft#259517 Cherry-pick d38eb0f from PR microsoft#259518. Avoid 0ms interval rescheduling in ConfigurationDefaultOverridesContribution. When ASSIGNMENT_REFETCH_INTERVAL is 0, skip rescheduling to prevent infinite loop of immediate scheduler execution. Co-authored-by: hediet <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: hediet <[email protected]>
1 parent 2c804a6 commit 9ace93e

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/vs/workbench/services/configuration/browser/configurationService.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1353,7 +1353,10 @@ class ConfigurationDefaultOverridesContribution extends Disposable implements IW
13531353

13541354
this.autoRefetchExperimentalSettingsScheduler = new RunOnceScheduler(() => {
13551355
this.processExperimentalSettings(this.autoRefetchExperimentalSettings, true);
1356-
this.autoRefetchExperimentalSettingsScheduler.schedule();
1356+
if (ASSIGNMENT_REFETCH_INTERVAL !== 0) {
1357+
// TODO@sandy081 wait for the promise returned by processExperimentalSettings to avoid unbounded queuing
1358+
this.autoRefetchExperimentalSettingsScheduler.schedule();
1359+
}
13571360
}, ASSIGNMENT_REFETCH_INTERVAL);
13581361

13591362
this.updateDefaults();

0 commit comments

Comments
 (0)