debug: handle runtime-registered dynamic config providers (microsoft#201030)

Fixes microsoft#198800

Author: connor4312

src/vs/workbench/contrib/debug/browser/debugActionViewItems.ts

@@ -130,13 +130,16 @@ export class StartDebugActionViewItem extends BaseActionViewItem {
 		selectBoxContainer.style.borderLeft = `1px solid ${asCssVariable(selectBorder)}`;
 		this.container.style.backgroundColor = asCssVariable(selectBackground);
 
-		this.debugService.getConfigurationManager().getDynamicProviders().then(providers => {
-			this.providers = providers;
-			if (this.providers.length > 0) {
+		const configManager = this.debugService.getConfigurationManager();
+		const updateDynamicConfigs = () => configManager.getDynamicProviders().then(providers => {
+			if (providers.length !== this.providers.length) {
+				this.providers = providers;
 				this.updateOptions();
 			}
 		});
 
+		this.toDispose.push(configManager.onDidChangeConfigurationProviders(updateDynamicConfigs));
+		updateDynamicConfigs();
 		this.updateOptions();
 	}
 

src/vs/workbench/contrib/debug/browser/debugConfigurationManager.ts

@@ -12,6 +12,7 @@ import { IJSONSchema } from 'vs/base/common/jsonSchema';
 import { DisposableStore, IDisposable, dispose } from 'vs/base/common/lifecycle';
 import * as objects from 'vs/base/common/objects';
 import * as resources from 'vs/base/common/resources';
+import { ThemeIcon } from 'vs/base/common/themables';
 import { URI as uri } from 'vs/base/common/uri';
 import * as nls from 'vs/nls';
 import { ConfigurationTarget, IConfigurationService } from 'vs/platform/configuration/common/configuration';
@@ -22,7 +23,6 @@ import { IJSONContributionRegistry, Extensions as JSONExtensions } from 'vs/plat
 import { IQuickInputService } from 'vs/platform/quickinput/common/quickInput';
 import { Registry } from 'vs/platform/registry/common/platform';
 import { IStorageService, StorageScope, StorageTarget } from 'vs/platform/storage/common/storage';
-import { ThemeIcon } from 'vs/base/common/themables';
 import { IUriIdentityService } from 'vs/platform/uriIdentity/common/uriIdentity';
 import { IWorkspaceContextService, IWorkspaceFolder, IWorkspaceFoldersChangeEvent, WorkbenchState } from 'vs/platform/workspace/common/workspace';
 import { IEditorPane } from 'vs/workbench/common/editor';
@@ -59,6 +59,8 @@ export class ConfigurationManager implements IConfigurationManager {
 	private readonly _onDidSelectConfigurationName = new Emitter<void>();
 	private configProviders: IDebugConfigurationProvider[];
 	private debugConfigurationTypeContext: IContextKey<string>;
+	private readonly _onDidChangeConfigurationProviders = new Emitter<void>();
+	public readonly onDidChangeConfigurationProviders = this._onDidChangeConfigurationProviders.event;
 
 	constructor(
 		private readonly adapterManager: IAdapterManager,
@@ -73,7 +75,7 @@ export class ConfigurationManager implements IConfigurationManager {
 		@IContextKeyService contextKeyService: IContextKeyService
 	) {
 		this.configProviders = [];
-		this.toDispose = [];
+		this.toDispose = [this._onDidChangeConfigurationProviders];
 		this.initLaunches();
 		this.setCompoundSchemaValues();
 		this.registerListeners();
@@ -92,9 +94,11 @@ export class ConfigurationManager implements IConfigurationManager {
 
 	registerDebugConfigurationProvider(debugConfigurationProvider: IDebugConfigurationProvider): IDisposable {
 		this.configProviders.push(debugConfigurationProvider);
+		this._onDidChangeConfigurationProviders.fire();
 		return {
 			dispose: () => {
 				this.unregisterDebugConfigurationProvider(debugConfigurationProvider);
+				this._onDidChangeConfigurationProviders.fire();
 			}
 		};
 	}
@@ -187,18 +191,24 @@ export class ConfigurationManager implements IConfigurationManager {
 			}
 
 			if (explicitTypes.length) {
-				return acc.concat(explicitTypes);
-			}
-
-			if (hasGenericEvent) {
+				explicitTypes.forEach(t => acc.add(t));
+			} else if (hasGenericEvent) {
 				const debuggerType = e.contributes?.debuggers?.[0].type;
-				return debuggerType ? acc.concat(debuggerType) : acc;
+				if (debuggerType) {
+					acc.add(debuggerType);
+				}
 			}
 
 			return acc;
-		}, [] as string[]);
+		}, new Set<string>());
+
+		for (const configProvider of this.configProviders) {
+			if (configProvider.triggerKind === DebugConfigurationProviderTriggerKind.Dynamic) {
+				debugDynamicExtensionsTypes.add(configProvider.type);
+			}
+		}
 
-		return debugDynamicExtensionsTypes.map(type => {
+		return [...debugDynamicExtensionsTypes].map(type => {
 			return {
 				label: this.adapterManager.getDebuggerLabel(type)!,
 				getProvider: async () => {

src/vs/workbench/contrib/debug/common/debug.ts

@@ -907,6 +907,11 @@ export interface IConfigurationManager {
 	 */
 	onDidSelectConfiguration: Event<void>;
 
+	/**
+	 * Allows to register on change of selected debug configuration.
+	 */
+	onDidChangeConfigurationProviders: Event<void>;
+
 	hasDebugConfigurationProvider(debugType: string, triggerKind?: DebugConfigurationProviderTriggerKind): boolean;
 	getDynamicProviders(): Promise<{ label: string; type: string; pick: () => Promise<{ launch: ILaunch; config: IConfig } | undefined> }[]>;