Merge pull request microsoft#209467 from microsoft/merogge/splits

meganrogge · web-flow · commit 9c892dba6a28 · 2024-04-03T14:34:30.000-07:00
fix join terminals bug
diff --git a/src/vs/workbench/contrib/terminal/browser/terminalGroupService.ts b/src/vs/workbench/contrib/terminal/browser/terminalGroupService.ts
@@ -391,7 +391,7 @@ export class TerminalGroupService extends Disposable implements ITerminalGroupSe
 					break;
 				}
 			}
-			if (!differentGroups) {
+			if (!differentGroups && group.terminalInstances.length === instances.length) {
 				return;
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -391,7 +391,7 @@ export class TerminalGroupService extends Disposable implements ITerminalGroupSe`
`391`	`391`	`break;`
`392`	`392`	`}`
`393`	`393`	`}`
`394`		`- if (!differentGroups) {`
	`394`	`+ if (!differentGroups && group.terminalInstances.length === instances.length) {`
`395`	`395`	`return;`
`396`	`396`	`}`
`397`	`397`	`}`