Skip to content

Commit 9ca1204

Browse files
Doc calling out GitHub OAuth client secret behavior (microsoft#242210)
1 parent 5b8244c commit 9ca1204

File tree

1 file changed

+4
-0
lines changed
  • extensions/github-authentication/src

1 file changed

+4
-0
lines changed

extensions/github-authentication/src/config.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ export interface IConfig {
1010
}
1111

1212
// For easy access to mixin client ID and secret
13+
//
14+
// NOTE: GitHub client secrets cannot be secured when running in a native client so in other words, the client secret is
15+
// not really a secret... so we allow the client secret in code. It is brought in before we publish VS Code. Reference:
16+
// https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/best-practices-for-creating-an-oauth-app#client-secrets
1317
export const Config: IConfig = {
1418
gitHubClientId: '01ab8ac9400c4e429b23'
1519
};

0 commit comments

Comments
 (0)