Fixes microsoft#136470 by not firing "onDidChange" when there was no change.

hediet · hediet · commit 9d092bc97a8e · 2021-11-05T10:15:19.000+01:00
diff --git a/src/vs/editor/common/model/bracketPairs/bracketPairsImpl.ts b/src/vs/editor/common/model/bracketPairs/bracketPairsImpl.ts
@@ -72,8 +72,11 @@ export class BracketPairs extends Disposable implements IBracketPairs {
 				this.onDidChangeEmitter.fire();
 			}
 		} else {
-			this.bracketPairsTree.clear();
-			this.onDidChangeEmitter.fire();
+			if (this.bracketPairsTree.value) {
+				this.bracketPairsTree.clear();
+				// Important: Don't call fire if there was no change!
+				this.onDidChangeEmitter.fire();
+			}
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -72,8 +72,11 @@ export class BracketPairs extends Disposable implements IBracketPairs {`
`72`	`72`	`this.onDidChangeEmitter.fire();`
`73`	`73`	`}`
`74`	`74`	`} else {`
`75`		`- this.bracketPairsTree.clear();`
`76`		`- this.onDidChangeEmitter.fire();`
	`75`	`+ if (this.bracketPairsTree.value) {`
	`76`	`+ this.bracketPairsTree.clear();`
	`77`	`+ // Important: Don't call fire if there was no change!`
	`78`	`+ this.onDidChangeEmitter.fire();`
	`79`	`+ }`
`77`	`80`	`}`
`78`	`81`	`}`
`79`	`82`