Skip to content

Commit 9d8052c

Browse files
committed
remove aria alert covered by help content
1 parent 9a3ddb3 commit 9d8052c

File tree

1 file changed

+0
-27
lines changed

1 file changed

+0
-27
lines changed

src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import 'vs/css!./media/notebookCellOutput';
1515
import { PixelRatio } from 'vs/base/browser/browser';
1616
import * as DOM from 'vs/base/browser/dom';
1717
import { IMouseWheelEvent, StandardMouseEvent } from 'vs/base/browser/mouseEvent';
18-
import * as aria from 'vs/base/browser/ui/aria/aria';
1918
import { IListContextMenuEvent } from 'vs/base/browser/ui/list/list';
2019
import { DeferredPromise, runWhenIdle, SequencerByKey } from 'vs/base/common/async';
2120
import { CancellationToken } from 'vs/base/common/cancellation';
@@ -91,7 +90,6 @@ import { INotebookLoggingService } from 'vs/workbench/contrib/notebook/common/no
9190
import { Schemas } from 'vs/base/common/network';
9291
import { DropIntoEditorController } from 'vs/editor/contrib/dropOrPasteInto/browser/dropIntoEditorController';
9392
import { CopyPasteController } from 'vs/editor/contrib/dropOrPasteInto/browser/copyPasteController';
94-
import { AccessibilityVerbositySettingId } from 'vs/workbench/contrib/accessibility/browser/accessibilityContribution';
9593

9694
const $ = DOM.$;
9795

@@ -2239,28 +2237,6 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
22392237
return undefined;
22402238
}
22412239

2242-
private _cellFocusAria(cell: ICellViewModel, focusItem: 'editor' | 'container' | 'output') {
2243-
const index = this._notebookViewModel?.getCellIndex(cell);
2244-
const verboseLabel = this.configurationService.getValue(AccessibilityVerbositySettingId.Notebook);
2245-
if (index !== undefined && index >= 0) {
2246-
let position = '';
2247-
switch (focusItem) {
2248-
case 'editor':
2249-
position = `the inner ${cell.cellKind === CellKind.Markup ? 'markdown' : 'code'} editor is focused` + (verboseLabel ? `, press escape to focus the cell container` : '');
2250-
break;
2251-
case 'output':
2252-
position = `the cell output is focused` + (verboseLabel ? `, press escape to focus the cell container` : '');
2253-
break;
2254-
case 'container':
2255-
position = `the ${cell.cellKind === CellKind.Markup ? 'markdown preview' : 'cell container'} is focused` + (verboseLabel ? `, press enter to focus the inner ${cell.cellKind === CellKind.Markup ? 'markdown' : 'code'} editor` : '');
2256-
break;
2257-
default:
2258-
break;
2259-
}
2260-
aria.alert(`Cell ${this._notebookViewModel?.getCellIndex(cell)}, ${position} `);
2261-
}
2262-
}
2263-
22642240
private _toggleNotebookCellSelection(selectedCell: ICellViewModel, selectFromPrevious: boolean): void {
22652241
const currentSelections = this._list.getSelectedElements();
22662242
const isSelected = currentSelections.includes(selectedCell);
@@ -2300,7 +2276,6 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
23002276

23012277
if (focusItem === 'editor') {
23022278
this.focusElement(cell);
2303-
this._cellFocusAria(cell, focusItem);
23042279
this._list.focusView();
23052280

23062281
cell.updateEditState(CellEditState.Editing, 'focusNotebookCell');
@@ -2330,7 +2305,6 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
23302305
}
23312306
} else if (focusItem === 'output') {
23322307
this.focusElement(cell);
2333-
this._cellFocusAria(cell, focusItem);
23342308

23352309
if (!this.hasEditorFocus()) {
23362310
this._list.focusView();
@@ -2359,7 +2333,6 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
23592333
cell.focusMode = CellFocusMode.Container;
23602334

23612335
this.focusElement(cell);
2362-
this._cellFocusAria(cell, focusItem);
23632336
if (!options?.skipReveal) {
23642337
if (typeof options?.focusEditorLine === 'number') {
23652338
this._cursorNavMode.set(true);

0 commit comments

Comments
 (0)