List find + breadcrumb fixes (microsoft#162394)

* fix list style overrides

fixes microsoft#158824

* make sure breadcrumbs doesn't disappear when using tree find

fixes microsoft#158767

Author: joaomoreno

src/vs/base/browser/ui/inputbox/inputBox.ts

@@ -58,7 +58,7 @@ export interface IInputValidator {
 }
 
 export interface IMessage {
-	readonly content: string;
+	readonly content?: string;
 	readonly formatContent?: boolean; // defaults to false
 	readonly type?: MessageType;
 }
@@ -396,7 +396,7 @@ export class InputBox extends Widget {
 		const styles = this.stylesForType(this.message.type);
 		this.element.style.border = styles.border ? `1px solid ${styles.border}` : '';
 
-		if (this.hasFocus() || force) {
+		if (this.message.content && (this.hasFocus() || force)) {
 			this._showMessage();
 		}
 	}
@@ -477,8 +477,8 @@ export class InputBox extends Widget {
 				};
 
 				const spanElement = (this.message.formatContent
-					? renderFormattedText(this.message.content, renderOptions)
-					: renderText(this.message.content, renderOptions));
+					? renderFormattedText(this.message.content!, renderOptions)
+					: renderText(this.message.content!, renderOptions));
 				spanElement.classList.add(this.classForType(this.message.type));
 
 				const styles = this.stylesForType(this.message.type);

src/vs/base/browser/ui/tree/abstractTree.ts

@@ -996,7 +996,11 @@ class FindController<T, TFilterData> implements IDisposable {
 		const noMatches = this.filter.totalCount > 0 && this.filter.matchCount === 0;
 
 		if (this.pattern && noMatches) {
-			this.widget?.showMessage({ type: MessageType.WARNING, content: localize('not found', "No elements found.") });
+			if (this.tree.options.showNotFoundMessage ?? true) {
+				this.widget?.showMessage({ type: MessageType.WARNING, content: localize('not found', "No elements found.") });
+			} else {
+				this.widget?.showMessage({ type: MessageType.WARNING });
+			}
 		} else {
 			this.widget?.clearMessage();
 		}
@@ -1062,6 +1066,7 @@ export interface IAbstractTreeOptionsUpdate extends ITreeRendererOptions {
 	readonly typeNavigationEnabled?: boolean;
 	readonly typeNavigationMode?: TypeNavigationMode;
 	readonly defaultFindMode?: TreeFindMode;
+	readonly showNotFoundMessage?: boolean;
 	readonly smoothScrolling?: boolean;
 	readonly horizontalScrolling?: boolean;
 	readonly mouseWheelScrollSensitivity?: number;

src/vs/platform/list/browser/listService.ts

@@ -1291,7 +1291,7 @@ class WorkbenchTreeInternals<TInput, T, TFilterData> {
 
 	updateStyleOverrides(overrideStyles?: IColorMapping): void {
 		dispose(this.styler);
-		this.styler = overrideStyles ? attachListStyler(this.tree, this.themeService, overrideStyles) : Disposable.None;
+		this.styler = attachListStyler(this.tree, this.themeService, overrideStyles);
 	}
 
 	dispose(): void {

src/vs/workbench/browser/parts/editor/breadcrumbsPicker.ts

@@ -381,6 +381,7 @@ export class BreadcrumbsFilePicker extends BreadcrumbsPicker {
 				identityProvider: new FileIdentityProvider(),
 				keyboardNavigationLabelProvider: new FileNavigationLabelProvider(),
 				accessibilityProvider: this._instantiationService.createInstance(FileAccessibilityProvider),
+				showNotFoundMessage: false,
 				overrideStyles: {
 					listBackground: breadcrumbsPickerBackground
 				},
@@ -474,6 +475,7 @@ export class BreadcrumbsOutlinePicker extends BreadcrumbsPicker {
 				collapseByDefault: true,
 				expandOnlyOnTwistieClick: true,
 				multipleSelectionSupport: false,
+				showNotFoundMessage: false
 			}
 		);
 	}