Skip to content

Commit a03cb7c

Browse files
authored
Adjusts inline edit <-> inline completion preference (microsoft#242169)
1 parent c202fb0 commit a03cb7c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/vs/editor/contrib/inlineCompletions/browser/model/inlineCompletionsModel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ export class InlineCompletionsModel extends Disposable {
282282
let inlineEdit: InlineCompletionWithUpdatedRange | undefined = undefined;
283283
const visibleCompletions: InlineCompletionWithUpdatedRange[] = [];
284284
for (const completion of c.inlineCompletions) {
285-
if (!completion.sourceInlineCompletion.isInlineEdit) {
285+
if (!(completion.sourceInlineCompletion.isInlineEdit || completion.sourceInlineCompletion.showInlineEditMenu)) {
286286
if (completion.isVisible(this.textModel, cursorPosition, reader)) {
287287
visibleCompletions.push(completion);
288288
}

src/vs/editor/contrib/inlineCompletions/browser/model/provideInlineCompletions.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -180,10 +180,10 @@ async function addRefAndCreateResult(
180180
completions.addRef();
181181
lists.push(completions);
182182
for (const item of completions.inlineCompletions.items) {
183-
if (!context.includeInlineEdits && item.isInlineEdit) {
183+
if (!context.includeInlineEdits && (item.isInlineEdit || item.showInlineEditMenu)) {
184184
continue;
185185
}
186-
if (!context.includeInlineCompletions && !item.isInlineEdit) {
186+
if (!context.includeInlineCompletions && !(item.isInlineEdit || item.showInlineEditMenu)) {
187187
continue;
188188
}
189189
const inlineCompletionItem = InlineCompletionItem.from(
@@ -197,7 +197,7 @@ async function addRefAndCreateResult(
197197
itemsByHash.set(inlineCompletionItem.hash(), inlineCompletionItem);
198198

199199
// Stop after first visible inline completion
200-
if (!item.isInlineEdit && context.triggerKind === InlineCompletionTriggerKind.Automatic) {
200+
if (!(item.isInlineEdit || item.showInlineEditMenu) && context.triggerKind === InlineCompletionTriggerKind.Automatic) {
201201
const minifiedEdit = inlineCompletionItem.toSingleTextEdit().removeCommonPrefix(new TextModelText(model));
202202
if (!minifiedEdit.isEmpty) {
203203
shouldStop = true;

0 commit comments

Comments
 (0)