Fixes microsoft#134177: unset LD_PRELOAD on Linux and consolidate code

Author: alexdima

src/vs/base/node/processes.ts

@@ -87,6 +87,35 @@ function terminateProcess(process: cp.ChildProcess, cwd?: string): Promise<Termi
 	return Promise.resolve({ success: true });
 }
 
+/**
+ * Remove dangerous environment variables that have caused crashes
+ * in forked processes (i.e. in ELECTRON_RUN_AS_NODE processes)
+ *
+ * @param env The env object to change
+ */
+export function removeDangerousEnvVariables(env: NodeJS.ProcessEnv | undefined): void {
+	if (!env) {
+		return;
+	}
+
+	// Unset `DEBUG`, as an invalid value might lead to process crashes
+	// See https://github.com/microsoft/vscode/issues/130072
+	delete env['DEBUG'];
+
+	if (Platform.isMacintosh) {
+		// Unset `DYLD_LIBRARY_PATH`, as it leads to process crashes
+		// See https://github.com/microsoft/vscode/issues/104525
+		// See https://github.com/microsoft/vscode/issues/105848
+		delete env['DYLD_LIBRARY_PATH'];
+	}
+
+	if (Platform.isLinux) {
+		// Unset `LD_PRELOAD`, as it might lead to process crashes
+		// See https://github.com/microsoft/vscode/issues/134177
+		delete env['LD_PRELOAD'];
+	}
+}
+
 export function getWindowsShell(env = process.env as Platform.IProcessEnvironment): string {
 	return env['comspec'] || 'cmd.exe';
 }

src/vs/base/parts/ipc/node/ipc.cp.ts

@@ -12,8 +12,7 @@ import * as errors from 'vs/base/common/errors';
 import { Emitter, Event } from 'vs/base/common/event';
 import { dispose, IDisposable, toDisposable } from 'vs/base/common/lifecycle';
 import { deepClone } from 'vs/base/common/objects';
-import { isMacintosh } from 'vs/base/common/platform';
-import { createQueuedSender } from 'vs/base/node/processes';
+import { createQueuedSender, removeDangerousEnvVariables } from 'vs/base/node/processes';
 import { ChannelClient as IPCClient, ChannelServer as IPCServer, IChannel, IChannelClient } from 'vs/base/parts/ipc/common/ipc';
 
 /**
@@ -202,11 +201,7 @@ export class Client implements IChannelClient, IDisposable {
 				forkOpts.execArgv = process.execArgv.filter(a => !/^--inspect(-brk)?=/.test(a)); // remove
 			}
 
-			if (isMacintosh && forkOpts.env) {
-				// Unset `DYLD_LIBRARY_PATH`, as it leads to process crashes
-				// See https://github.com/microsoft/vscode/issues/105848
-				delete forkOpts.env['DYLD_LIBRARY_PATH'];
-			}
+			removeDangerousEnvVariables(forkOpts.env);
 
 			this.child = fork(this.modulePath, args, forkOpts);
 

src/vs/platform/sharedProcess/electron-browser/sharedProcessWorkerMain.ts

@@ -10,7 +10,7 @@ import { toErrorMessage } from 'vs/base/common/errorMessage';
 import { Event, Emitter } from 'vs/base/common/event';
 import { Disposable } from 'vs/base/common/lifecycle';
 import { deepClone } from 'vs/base/common/objects';
-import { isMacintosh } from 'vs/base/common/platform';
+import { removeDangerousEnvVariables } from 'vs/base/node/processes';
 import { ISharedProcessWorkerConfiguration } from 'vs/platform/sharedProcess/common/sharedProcessWorkerService';
 import { SharedProcessWorkerMessages, ISharedProcessToWorkerMessage, ISharedProcessWorkerEnvironment } from 'vs/platform/sharedProcess/electron-browser/sharedProcessWorker';
 
@@ -140,15 +140,7 @@ class SharedProcessWorkerProcess extends Disposable {
 			VSCODE_PARENT_PID: String(process.pid)
 		};
 
-		// Unset `DEBUG`, as an invalid value might lead to crashes
-		// See https://github.com/microsoft/vscode/issues/130072
-		delete env['DEBUG'];
-
-		if (isMacintosh) {
-			// Unset `DYLD_LIBRARY_PATH`, as it leads to extension host crashes
-			// See https://github.com/microsoft/vscode/issues/104525
-			delete env['DYLD_LIBRARY_PATH'];
-		}
+		removeDangerousEnvVariables(env);
 
 		return env;
 	}

src/vs/workbench/services/extensions/electron-browser/localProcessExtensionHost.ts

@@ -48,6 +48,7 @@ import { IShellEnvironmentService } from 'vs/workbench/services/environment/elec
 import { IExtensionHostProcessOptions, IExtensionHostStarter } from 'vs/platform/extensions/common/extensionHostStarter';
 import { SerializedError } from 'vs/base/common/errors';
 import { StopWatch } from 'vs/base/common/stopwatch';
+import { removeDangerousEnvVariables } from 'vs/base/node/processes';
 
 export interface ILocalProcessExtensionHostInitData {
 	readonly autoStart: boolean;
@@ -239,15 +240,7 @@ export class LocalProcessExtensionHost implements IExtensionHost {
 					objects.mixin(env, this._environmentService.debugExtensionHost.env);
 				}
 
-				// Unset `DEBUG`, as an invalid value might lead to extension host crashes
-				// See https://github.com/microsoft/vscode/issues/130072
-				delete env['DEBUG'];
-
-				if (platform.isMacintosh) {
-					// Unset `DYLD_LIBRARY_PATH`, as it leads to extension host crashes
-					// See https://github.com/microsoft/vscode/issues/104525
-					delete env['DYLD_LIBRARY_PATH'];
-				}
+				removeDangerousEnvVariables(env);
 
 				if (this._isExtensionDevHost) {
 					// Unset `VSCODE_CODE_CACHE_PATH` when developing extensions because it might