Prevent exponential function call in getFigSuggestions

Author: Tyriar

extensions/terminal-suggest/src/fig/figInterface.ts

@@ -46,16 +46,26 @@ export async function getFigSuggestions(
 		items: [],
 	};
 	const currentCommand = currentCommandAndArgString.split(' ')[0];
+
+	// Assemble a map to allow O(1) access to the available command from a spec
+	// label. The label does not include an extension on Windows.
+	const specLabelToAvailableCommandMap = new Map<string, ICompletionResource>();
+	for (const command of availableCommands) {
+		let label = typeof command.label === 'string' ? command.label : command.label.label;
+		if (osIsWindows()) {
+			label = removeAnyFileExtension(label);
+		}
+		specLabelToAvailableCommandMap.set(label, command);
+	}
+
 	for (const spec of specs) {
 		const specLabels = getFigSuggestionLabel(spec);
 
 		if (!specLabels) {
 			continue;
 		}
 		for (const specLabel of specLabels) {
-			const availableCommand = (osIsWindows()
-				? availableCommands.find(command => (typeof command.label === 'string' ? command.label : command.label.label).match(new RegExp(`${specLabel}(\\.[^ ]+)?$`)))
-				: availableCommands.find(command => (typeof command.label === 'string' ? command.label : command.label.label) === (specLabel)));
+			const availableCommand = specLabelToAvailableCommandMap.get(specLabel);
 			if (!availableCommand || (token && token.isCancellationRequested)) {
 				continue;
 			}

extensions/terminal-suggest/src/terminalSuggestMain.ts

@@ -295,6 +295,7 @@ export async function activate(context: vscode.ExtensionContext) {
 				}
 			}
 
+
 			if (terminal.shellIntegration?.cwd && (result.filesRequested || result.foldersRequested)) {
 				return new vscode.TerminalCompletionList(result.items, {
 					filesRequested: result.filesRequested,