Skip to content

Commit a19b2d5

Browse files
authored
actions - ensure checked: undefined when action is not a checkbox (fix microsoft#203491) (microsoft#203593)
1 parent 3adea2f commit a19b2d5

File tree

3 files changed

+1
-3
lines changed

3 files changed

+1
-3
lines changed

src/vs/base/common/actions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ export function toAction(props: { id: string; label: string; enabled?: boolean;
264264
label: props.label,
265265
class: props.class,
266266
enabled: props.enabled ?? true,
267-
checked: props.checked ?? false,
267+
checked: props.checked,
268268
run: async (...args: unknown[]) => props.run(...args),
269269
tooltip: props.label
270270
};

src/vs/workbench/contrib/preferences/browser/settingsSearchMenu.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ export class SettingsSearchFilterDropdownMenuActionViewItem extends DropdownMenu
5757
tooltip,
5858
class: undefined,
5959
enabled: true,
60-
checked: false,
6160
run: () => { this.doSearchWidgetAction(queryToAppend, triggerSuggest); }
6261
};
6362
}

src/vs/workbench/contrib/testing/browser/testingExplorerFilter.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,6 @@ class FiltersDropdownMenuActionViewItem extends DropdownMenuActionViewItem {
230230
tooltip: ''
231231
},
232232
{
233-
checked: false,
234233
class: undefined,
235234
enabled: this.testService.excluded.hasAny,
236235
id: 'removeExcluded',

0 commit comments

Comments
 (0)