Make fix more generic

Author: Tyriar

src/vs/workbench/contrib/terminal/browser/terminalInstance.ts

@@ -485,11 +485,9 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
 				const defaultProfile = (await this._terminalProfileResolverService.getDefaultProfile({ remoteAuthority: this.remoteAuthority, os }));
 				this.shellLaunchConfig.executable = defaultProfile.path;
 				this.shellLaunchConfig.args = defaultProfile.args;
-				// Prevent debug icon from being overwritten
-				if (!(this.shellLaunchConfig.icon && 'id' in this.shellLaunchConfig.icon && this.shellLaunchConfig.icon.id === Codicon.debug.id)) {
-					this.shellLaunchConfig.icon = defaultProfile.icon;
-				}
-				this.shellLaunchConfig.color = defaultProfile.color;
+				// Only use default icon and color if they are undefined in the SLC
+				this.shellLaunchConfig.icon ??= defaultProfile.icon;
+				this.shellLaunchConfig.color ??= defaultProfile.color;
 			}
 
 			await this._createProcess();