only select text when navigating changes for screen readers (microsoft#172459)

meganrogge · web-flow · commit a60a1cfe2c62 · 2023-01-25T22:36:10.000+01:00
fix microsoft#172458
diff --git a/src/vs/editor/browser/widget/diffNavigator.ts b/src/vs/editor/browser/widget/diffNavigator.ts
@@ -241,7 +241,7 @@ export class DiffNavigator extends Disposable implements IDiffNavigator {
 		}
 
 		const codeEditor = this._codeEditorService.getActiveCodeEditor();
-		if (codeEditor && insertedOrModified && this._accessibilityService.isScreenReaderOptimized()) {
+		if (jumpToChange && codeEditor && insertedOrModified && this._accessibilityService.isScreenReaderOptimized()) {
 			codeEditor.setSelection({ startLineNumber: lineNumber, startColumn: 0, endLineNumber: lineNumber, endColumn: Number.MAX_VALUE });
 			codeEditor.writeScreenReaderContent('diff-navigation');
 		}

Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,7 @@ export class DiffNavigator extends Disposable implements IDiffNavigator {`
`241`	`241`	`}`
`242`	`242`
`243`	`243`	`const codeEditor = this._codeEditorService.getActiveCodeEditor();`
`244`		`- if (codeEditor && insertedOrModified && this._accessibilityService.isScreenReaderOptimized()) {`
	`244`	`+ if (jumpToChange && codeEditor && insertedOrModified && this._accessibilityService.isScreenReaderOptimized()) {`
`245`	`245`	`codeEditor.setSelection({ startLineNumber: lineNumber, startColumn: 0, endLineNumber: lineNumber, endColumn: Number.MAX_VALUE });`
`246`	`246`	`codeEditor.writeScreenReaderContent('diff-navigation');`
`247`	`247`	`}`