Skip to content

Commit a651ea4

Browse files
committed
1 parent 6e34580 commit a651ea4

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/vs/workbench/services/editor/browser/editorOverrideService.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,8 @@ export class EditorOverrideService extends Disposable implements IEditorOverride
137137
// If it's the currently active editor we shouldn't do anything
138138
const activeEditor = group.activeEditor;
139139
const isActive = activeEditor ? activeEditor.editorId === selectedEditor.editorInfo.id && isEqual(activeEditor.resource, resource) : false;
140-
if (isActive) {
141-
return OverrideStatus.NONE;
140+
if (activeEditor && isActive) {
141+
return { editor: activeEditor, options };
142142
}
143143
const input = await this.doOverrideEditorInput(editor, group, selectedEditor);
144144
if (conflictingDefault && input) {

src/vs/workbench/services/editor/test/browser/editorService.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1036,7 +1036,7 @@ suite('EditorService', () => {
10361036
pane = await service.openEditor({ resource: URI.file('file.editor-service-override-tests') });
10371037
pane = await service.openEditor({ resource: URI.file('file.editor-service-override-tests'), options: { sticky: true, preserveFocus: true } });
10381038

1039-
assert.ok(pane instanceof TestTextFileEditor);
1039+
assert.ok(pane instanceof TestEditorWithOptions);
10401040
assert.strictEqual(pane.lastSetOptions?.sticky, true);
10411041
assert.strictEqual(pane.lastSetOptions?.preserveFocus, true);
10421042
});

0 commit comments

Comments
 (0)