debt - move storage main into global storage

The other location one level up is being file watched and storage file changes constantly.

Author: bpasero

src/vs/code/node/cliProcessMain.ts

@@ -165,7 +165,7 @@ class CliMain extends Disposable {
 				commonProperties: (async () => {
 					let machineId: string | undefined = undefined;
 					try {
-						const storageContents = await Promises.readFile(joinPath(environmentService.appSettingsHome, 'storage.json').fsPath);
+						const storageContents = await Promises.readFile(joinPath(environmentService.globalStorageHome, 'storage.json').fsPath);
 						machineId = JSON.parse(storageContents.toString())[machineIdKey];
 					} catch (error) {
 						if (error.code !== 'ENOENT') {

src/vs/platform/state/electron-main/stateMainService.ts

@@ -154,7 +154,7 @@ export class StateMainService implements IStateMainService {
 	private static readonly STATE_FILE = 'storage.json';
 
 	private readonly legacyStateFilePath = URI.file(join(this.environmentMainService.userDataPath, StateMainService.STATE_FILE));
-	private readonly stateFilePath = joinPath(this.environmentMainService.appSettingsHome, StateMainService.STATE_FILE);
+	private readonly stateFilePath = joinPath(this.environmentMainService.globalStorageHome, StateMainService.STATE_FILE);
 
 	private readonly fileStorage: FileStorage;