Skip to content

Commit a74a764

Browse files
authored
Don't fail to send notebook open perf when reopening the same notebook in an editor (microsoft#166235)
Fix microsoft#135834
1 parent 964dc54 commit a74a764

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/vs/workbench/contrib/notebook/browser/notebookEditor.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ export class NotebookEditor extends EditorPane implements INotebookEditorPane {
256256
extensionActivated: number;
257257
inputLoaded: number;
258258
webviewCommLoaded: number;
259-
customMarkdownLoaded: number;
259+
customMarkdownLoaded: number | undefined;
260260
editorLoaded: number;
261261
};
262262

@@ -272,7 +272,6 @@ export class NotebookEditor extends EditorPane implements INotebookEditorPane {
272272
startTime !== undefined
273273
&& extensionActivated !== undefined
274274
&& inputLoaded !== undefined
275-
&& customMarkdownLoaded !== undefined
276275
&& editorLoaded !== undefined
277276
) {
278277
this.telemetryService.publicLog2<WorkbenchNotebookOpenEvent, WorkbenchNotebookOpenClassification>('notebook/editorOpenPerf', {
@@ -282,11 +281,11 @@ export class NotebookEditor extends EditorPane implements INotebookEditorPane {
282281
extensionActivated: extensionActivated - startTime,
283282
inputLoaded: inputLoaded - startTime,
284283
webviewCommLoaded: inputLoaded - startTime,
285-
customMarkdownLoaded: customMarkdownLoaded - startTime,
284+
customMarkdownLoaded: typeof customMarkdownLoaded === 'number' ? customMarkdownLoaded - startTime : undefined,
286285
editorLoaded: editorLoaded - startTime
287286
});
288287
} else {
289-
console.warn(`notebook file open perf marks are broken: startTime ${startTime}, extensionActiviated ${extensionActivated}, inputLoaded ${inputLoaded}, customMarkdownLoaded ${customMarkdownLoaded}, editorLoaded ${editorLoaded}`);
288+
console.warn(`notebook file open perf marks are broken: startTime ${startTime}, extensionActivated ${extensionActivated}, inputLoaded ${inputLoaded}, customMarkdownLoaded ${customMarkdownLoaded}, editorLoaded ${editorLoaded}`);
290289
}
291290
}
292291
} catch (e) {

0 commit comments

Comments
 (0)