Skip to content

Commit a821bbf

Browse files
Remove grid lines and "Presets" in wording (microsoft#238150)
Cleaner.
1 parent 60230a4 commit a821bbf

File tree

2 files changed

+1
-35
lines changed

2 files changed

+1
-35
lines changed

src/vs/platform/quickinput/browser/quickInputController.ts

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -897,9 +897,6 @@ class QuickInputDragAndDropController extends Disposable {
897897

898898
private readonly _snapThreshold = 20;
899899
private readonly _snapLineHorizontalRatio = 0.25;
900-
private readonly _snapLineHorizontal: HTMLElement;
901-
private readonly _snapLineVertical1: HTMLElement;
902-
private readonly _snapLineVertical2: HTMLElement;
903900

904901
private _quickInputAlignmentContext = QuickInputAlignmentContextKey.bindTo(this._contextKeyService);
905902

@@ -911,22 +908,11 @@ class QuickInputDragAndDropController extends Disposable {
911908
@IContextKeyService private readonly _contextKeyService: IContextKeyService
912909
) {
913910
super();
914-
915-
this._snapLineHorizontal = dom.append(this._container, $('.quick-input-widget-snapline.horizontal.hidden'));
916-
this._snapLineVertical1 = dom.append(this._container, $('.quick-input-widget-snapline.vertical.hidden'));
917-
this._snapLineVertical2 = dom.append(this._container, $('.quick-input-widget-snapline.vertical.hidden'));
918-
919911
this.registerMouseListeners();
920912
}
921913

922914
reparentUI(container: HTMLElement): void {
923915
this._container = container;
924-
this._snapLineHorizontal.remove();
925-
this._snapLineVertical1.remove();
926-
this._snapLineVertical2.remove();
927-
dom.append(this._container, this._snapLineHorizontal);
928-
dom.append(this._container, this._snapLineVertical1);
929-
dom.append(this._container, this._snapLineVertical2);
930916
}
931917

932918
setAlignment(alignment: 'top' | 'center' | { top: number; left: number }, done = true): void {
@@ -1000,7 +986,6 @@ class QuickInputDragAndDropController extends Disposable {
1000986
mouseMoveEvent.preventDefault();
1001987

1002988
if (!isMovingQuickInput) {
1003-
this._showSnapLines(snapCoordinateY, snapCoordinateX);
1004989
isMovingQuickInput = true;
1005990
}
1006991

@@ -1036,9 +1021,6 @@ class QuickInputDragAndDropController extends Disposable {
10361021
// Mouse up
10371022
const mouseUpListener = dom.addDisposableGenericMouseUpListener(activeWindow, (e: MouseEvent) => {
10381023
if (isMovingQuickInput) {
1039-
// Hide snaplines
1040-
this._hideSnapLines();
1041-
10421024
// Save position
10431025
const state = this.dndViewState.get();
10441026
this.dndViewState.set({ top: state?.top, left: state?.left, done: true }, undefined);
@@ -1062,20 +1044,4 @@ class QuickInputDragAndDropController extends Disposable {
10621044
private _getCenterXSnapValue() {
10631045
return Math.round(this._container.clientWidth / 2) - Math.round(this._quickInputContainer.clientWidth / 2);
10641046
}
1065-
1066-
private _showSnapLines(horizontal: number, vertical: number) {
1067-
this._snapLineHorizontal.style.top = `${horizontal}px`;
1068-
this._snapLineVertical1.style.left = `${vertical}px`;
1069-
this._snapLineVertical2.style.left = `${vertical + this._quickInputContainer.clientWidth}px`;
1070-
1071-
this._snapLineHorizontal.classList.remove('hidden');
1072-
this._snapLineVertical1.classList.remove('hidden');
1073-
this._snapLineVertical2.classList.remove('hidden');
1074-
}
1075-
1076-
private _hideSnapLines() {
1077-
this._snapLineHorizontal.classList.add('hidden');
1078-
this._snapLineVertical1.classList.add('hidden');
1079-
this._snapLineVertical2.classList.add('hidden');
1080-
}
10811047
}

src/vs/workbench/browser/actions/layoutActions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1491,7 +1491,7 @@ registerAction2(class CustomizeLayoutAction extends Action2 {
14911491
...AlignPanelActions.map(toQuickPickItem),
14921492
{
14931493
type: 'separator',
1494-
label: localize('quickOpen', "Quick Input Position Presets")
1494+
label: localize('quickOpen', "Quick Input Position")
14951495
},
14961496
...QuickInputActions.map(toQuickPickItem),
14971497
{

0 commit comments

Comments
 (0)