rename suggestions: fix: missing sparkle icon when automatic suggestions are off

ulugbekna · ulugbekna · commit a8608a26c0b4 · 2024-04-24T18:45:52.000+05:00
diff --git a/src/vs/editor/contrib/rename/browser/renameWidget.ts b/src/vs/editor/contrib/rename/browser/renameWidget.ts
@@ -370,6 +370,9 @@ export class RenameWidget implements IRenameWidget, IContentWidget, IDisposable
 		}
 	}
 
+	/**
+	 * @param requestRenameCandidates is `undefined` when there are no rename suggestion providers
+	 */
 	getInput(
 		where: IRange,
 		currentName: string,
@@ -526,6 +529,7 @@ export class RenameWidget implements IRenameWidget, IContentWidget, IDisposable
 			const candidates = this._requestRenameCandidatesOnce(triggerKind, this._renameCandidateProvidersCts.token);
 
 			if (candidates.length === 0) {
+				this._inputWithButton.setSparkleButton();
 				return;
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -370,6 +370,9 @@ export class RenameWidget implements IRenameWidget, IContentWidget, IDisposable`
`370`	`370`	`}`
`371`	`371`	`}`
`372`	`372`
	`373`	`+ /**`
	`374`	+ * @param requestRenameCandidates is `undefined` when there are no rename suggestion providers
	`375`	`+ */`
`373`	`376`	`getInput(`
`374`	`377`	`where: IRange,`
`375`	`378`	`currentName: string,`
`@@ -526,6 +529,7 @@ export class RenameWidget implements IRenameWidget, IContentWidget, IDisposable`
`526`	`529`	`const candidates = this._requestRenameCandidatesOnce(triggerKind, this._renameCandidateProvidersCts.token);`
`527`	`530`
`528`	`531`	`if (candidates.length === 0) {`
	`532`	`+ this._inputWithButton.setSparkleButton();`
`529`	`533`	`return;`
`530`	`534`	`}`
`531`	`535`