Skip to content

Commit a9ba067

Browse files
authored
fix: Not populating extension when selecting notebook kernel (microsoft#197619) (microsoft#197810)
When selecting a notebook kernel, prompt was saying "Select kernel from undefined". "Undefined" here was supported to be the extension name. When the quick pick items are generated, they are generated with a value of "label". Nothing else references or populates a property of "source", so seems safe to change the code to reference "label" instead.
1 parent 0d9e099 commit a9ba067

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/vs/workbench/contrib/notebook/browser/viewParts/notebookKernelQuickPickStrategy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -600,7 +600,7 @@ export class KernelPickerMRUStrategy extends KernelPickerStrategyBase {
600600
await this._selecteKernel(notebook, selectedKernelPickItem.kernel);
601601
return true;
602602
} else if (isGroupedKernelsPick(selectedKernelPickItem)) {
603-
await this._selectOneKernel(notebook, selectedKernelPickItem.source, selectedKernelPickItem.kernels);
603+
await this._selectOneKernel(notebook, selectedKernelPickItem.label, selectedKernelPickItem.kernels);
604604
return true;
605605
} else if (isSourcePick(selectedKernelPickItem)) {
606606
// selected explicilty, it should trigger the execution?

0 commit comments

Comments
 (0)