Merge pull request microsoft#135914 from microsoft/digitarald/lang-rec-fix

sandy081 · web-flow · commit aaa4e0a34146 · 2021-10-27T09:39:16.000+02:00
Fix placeholder for extension recommendation treatment
diff --git a/src/vs/workbench/contrib/extensions/browser/fileBasedRecommendations.ts b/src/vs/workbench/contrib/extensions/browser/fileBasedRecommendations.ts
@@ -282,7 +282,8 @@ export class FileBasedRecommendations extends ExtensionRecommendations {
 			return false;
 		}
 
-		const message = await this.tasExperimentService.getTreatment<string>('languageRecommendationMessage') ?? localize('reallyRecommended', "Do you want to install the recommended extensions for {0}?", name);
+		const treatmentMessage = await this.tasExperimentService.getTreatment<string>('languageRecommendationMessage');
+		const message = treatmentMessage ? treatmentMessage.replace('{0}', name) : localize('reallyRecommended', "Do you want to install the recommended extensions for {0}?", name);
 
 		this.extensionRecommendationNotificationService.promptImportantExtensionsInstallNotification([extensionId], message, `@id:${extensionId}`, RecommendationSource.FILE)
 			.then(result => {

Original file line number	Diff line number	Diff line change
`@@ -282,7 +282,8 @@ export class FileBasedRecommendations extends ExtensionRecommendations {`
`282`	`282`	`return false;`
`283`	`283`	`}`
`284`	`284`
`285`		`- const message = await this.tasExperimentService.getTreatment<string>('languageRecommendationMessage') ?? localize('reallyRecommended', "Do you want to install the recommended extensions for {0}?", name);`
	`285`	`+ const treatmentMessage = await this.tasExperimentService.getTreatment<string>('languageRecommendationMessage');`
	`286`	`+ const message = treatmentMessage ? treatmentMessage.replace('{0}', name) : localize('reallyRecommended', "Do you want to install the recommended extensions for {0}?", name);`
`286`	`287`
`287`	`288`	this.extensionRecommendationNotificationService.promptImportantExtensionsInstallNotification([extensionId], message, `@id:${extensionId}`, RecommendationSource.FILE)
`288`	`289`	`.then(result => {`